Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Fixups for klone download #62

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

mtauraso
Copy link
Collaborator

  • Added configs so image/variance/mask layer downloads can be configured.
  • Put filter lower in the sort order for dC.Rect so that duplicate dowloading in a resume situation is minimized for large downloads.
  • Concurrent connection error is now correct to our understanding of HSC's server-side behavior.

- Added configs so image/variance/mask layer downloads can be configured.
- Put filter lower in the sort order for dC.Rect so that duplicate dowloading
  in a resume situation is minimized for large downloads.
@mtauraso mtauraso linked an issue Sep 13, 2024 that may be closed by this pull request
@mtauraso mtauraso self-assigned this Sep 13, 2024
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 38.90%. Comparing base (3ee8380) to head (2ba53fd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/fibad/download.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #62   +/-   ##
=======================================
  Coverage   38.90%   38.90%           
=======================================
  Files          17       17           
  Lines         712      712           
=======================================
  Hits          277      277           
  Misses        435      435           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Before [3ee8380] After [55ecdc1] Ratio Benchmark (Parameter)
2.44±1s 3.40±1s ~1.39 benchmarks.time_computation
1.38k 1.83k 1.32 benchmarks.mem_list

Click here to view all benchmarks.

Copy link
Collaborator

@aritraghsh09 aritraghsh09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.
While reading the code, an enhancement came to mind which won't be needed for our work, but might be important later for other users.
I have opened the issue here -- #63

@mtauraso mtauraso merged commit c8c433f into main Sep 17, 2024
8 of 9 checks passed
@mtauraso mtauraso deleted the issue/61/optimize-bandwidth branch September 17, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize downloader for 10 connections
2 participants