Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vello_editor: Use PresentMode::Mailbox when available. #144

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

xorgy
Copy link
Member

@xorgy xorgy commented Oct 22, 2024

AutoVsync/FIFO introduces unnecessary latency, especially on X11. There aren't animations in vello_editor so the downside (extra work) is not significant.

@tomcur
Copy link
Member

tomcur commented Oct 23, 2024

As a data point: with this PR the example now works on my platform (Wayland on AMD GPU), previously it would nearly instantly crash with failed to get surface texture: Timeout, unless I changed AutoVsync to AutoNoVsync (and maybe Mailbox would've also worked).

@xorgy
Copy link
Member Author

xorgy commented Oct 23, 2024

@tomcur that is certainly odd! AutoVsync should fall back to FIFO, which should be supported on all platforms including Wayland... but with that message it's apparently less about compatibility, but rather about missing a deadline.
As for AutoNoVsync, it's possible it selected Mailbox on your system.

AutoVsync/FIFO introduces unnecessary latency, especially on X11.
Copy link
Collaborator

@dfrg dfrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Fixes intolerable latency on Windows as well.

@xorgy xorgy added this pull request to the merge queue Oct 23, 2024
Merged via the queue into linebender:main with commit 91b47a3 Oct 23, 2024
20 checks passed
@xorgy xorgy deleted the vello-editor-mailbox branch October 23, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants