Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for elevation, alias border-radius token, launch button tokens #61

Merged
merged 16 commits into from
Sep 13, 2024

Conversation

davyd-akamai
Copy link
Collaborator

@davyd-akamai davyd-akamai commented Aug 21, 2024

Change Summary

Breaking Changes

  • Restructured calendar background tokens for improved consistency and flexibility
    • Updated token: token-component-calendar-selected-item-background-default
    • Updated token: token-component-calendar-selected-item-background-hover

New Features

  • Introduced inProgress token for ProgressBar component
  • Added topGradient token for Appbar component
  • Implemented new background tokens:
    • rangeHover for date range selection
    • activeDateHover for active date hover states
  • Created borderRadius alias token for unified styling
  • Introduced launch button tokens (experimental)
    • Note: These tokens are connected to global styles and may be subject to change as we evaluate their inclusion in CDS 2.0. Dark mode styles are pending.

Enhancements

  • Refined elevation token blur for improved visual depth

jaalah-akamai and others added 3 commits July 31, 2024 11:16
Co-authored-by: Davyd Melkon <131438868+davyd-akamai@users.noreply.github.com>
Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com>
Default border raduis alias token
@davyd-akamai
Copy link
Collaborator Author

Launch button will be connected to global tokens, since we're still investigating if this button will be used in the CDS 2.0. Dark mode styles are not defined yet

@jaalah-akamai
Copy link
Collaborator

We're running into an issue parsing the linear gradient. I need to look into this https://github.com/linode/design-language-system/pull/61/files#diff-342f83c57db10e0bec303f072c2b93b04ddade6fc4ba656e182e07dd2cf9202fR770

@@ -1435,6 +1445,13 @@
"type": "color"
}
}
},
"borderRadius": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davyd-akamai We can't have this be the same name as the global token. Maybe we rename this radius? Or can we just put this under border.borderRadius?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved it under border, but let's talk about it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose "border" will not work, since in a Tokens Studio this property is for a border-width (as far as I remember). But let's talk about it

@davyd-akamai
Copy link
Collaborator Author

@jaalah-akamai Here will be one more breaking change to a stepper component. UIE team is aware of it.

@davyd-akamai davyd-akamai self-assigned this Sep 11, 2024
@jaalah-akamai jaalah-akamai deleted the branch linode:staging September 11, 2024 17:03
@jaalah-akamai jaalah-akamai reopened this Sep 13, 2024
Copy link
Collaborator

@jaalah-akamai jaalah-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jaalah-akamai jaalah-akamai merged commit b5b17cb into linode:staging Sep 13, 2024
1 check passed
jaalah-akamai added a commit that referenced this pull request Sep 18, 2024
* fix: expand composite objects and convert rem to px (#55)

Co-authored-by: Davyd Melkon <131438868+davyd-akamai@users.noreply.github.com>
Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com>

* Shadow blur value fix

* Launch button tokens
Default border raduis alias token

* Launch split menu button tokens

* New "rangeHover" and "activeDateHover" interaction tokens, calendar tokens structure update

* New global gradient token and new component tokens for the Appbar and Progress Bar components that use gradients

* Add descriptions

* Remove extensions from linear gradient

* Update branch with latest and fix border radius and linear gradient

* Numeric spinner text color property fix

* Horizontal stepper structure update
Error tag new background token

* New tokens for KPI bar: background token, disabled state for KPIs
New alias accent disabled token

* Update BorderRadius to Radius

* Update BorderRadius to Radius

---------

Co-authored-by: Jaalah Ramos <125309814+jaalah-akamai@users.noreply.github.com>
Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com>
@davyd-akamai davyd-akamai deleted the features branch September 18, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants