Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move dependencies to devDependencies #62

Conversation

bnussman-akamai
Copy link
Member

Description 📝

  • Moves packages in dependencies to devDependencies because this packages's output doesn't depend on any packages 📦
  • This should make result in clearer installation for packages that consume this package 🧹

Preview 📷

This is what http://github.com/linode/manager's lockfile looks like.
Screenshot 2024-08-27 at 2 38 26 PM

This is what it will look like after

Screenshot 2024-08-27 at 2 42 59 PM

@jaalah-akamai
Copy link
Collaborator

@bnussman Sorry about this! I probably could put better contributing guidelines in place, but we have these changes already in staging: #58. For this repo, open PRs should point at staging.

@bnussman-akamai
Copy link
Member Author

Ohh I see! Got it!

Seems a bit unusual to have a staging branch for a package 📦. Any reason to not just deploy directly from the main branch?

@bnussman-akamai
Copy link
Member Author

Resolved by #58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants