Skip to content

Commit

Permalink
ci: Fix workflow failures in PRs due to slack notify step (#588)
Browse files Browse the repository at this point in the history
* allow some vars to be shared

* add target branch

* remove target branch

* revert to push_request and only run slack notify when push to main
  • Loading branch information
ykim-1 authored Oct 7, 2024
1 parent 1e2090b commit 34f622c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:

- name: Fail if changes
run: git diff-index --exit-code HEAD

test:
runs-on: ubuntu-latest
env:
Expand Down Expand Up @@ -81,7 +81,7 @@ jobs:
notify-slack:
runs-on: ubuntu-latest
needs: [test]
if: always() && github.repository == 'linode/linodego' # Run even if integration tests fail and only on main repository
if: always() && github.ref == 'refs/heads/main' && github.event_name == 'push' # Run even if integration tests fail and only on main repository

steps:
- name: Notify Slack
Expand Down

0 comments on commit 34f622c

Please sign in to comment.