-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Resty as a dependency #576
base: proj/resty-migration
Are you sure you want to change the base?
Drop Resty as a dependency #576
Conversation
52823e7
to
92c4da8
Compare
bc4dc02
to
519fdcd
Compare
27bad2e
to
117b42b
Compare
2fa956d
to
b584283
Compare
c813c02
to
8cbafb0
Compare
39f6fed
to
daa932b
Compare
daa932b
to
77adeb4
Compare
Running the TF cross-test workflow against these changes here: https://github.com/lgarber-akamai/linodego/actions/runs/11111815305/job/30872572090 edit: Oops, I forgot to address the retry condition breaking changes. I'll fix that up on my TF fork and report back 🙂 |
* build(deps): bump golang.org/x/text from 0.18.0 to 0.19.0 Bumps [golang.org/x/text](https://github.com/golang/text) from 0.18.0 to 0.19.0. - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.18.0...v0.19.0) --- updated-dependencies: - dependency-name: golang.org/x/text dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Ran make tidy --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: ezilber-akamai <ezilber@akamai.com>
* allow some vars to be shared * add target branch * remove target branch * revert to push_request and only run slack notify when push to main
d617c7e
to
09a3567
Compare
I think it was implemented in a previous PR, but would it make sense for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this pretty thoroughly and everything seems to be working well, great work!
📝 Description
Linodego currently uses the go-resty package to manage all HTTP requests made to the API. This includes logic for authentication, JSON marshaling/unmarshaling, request retries, and debug outputs.
Unfortunately this package has caused various issues for linodego users, including:
Because of these issues, Resty is being dropped as a dependency in favor of the mature and widely adopted net/http package.
✔️ How to Test
Run the unit test suite with
make testunit
Run the integration test suite with
make testint