feat: [UIE-8074] - DBaaS GA Summary tab #11091
Conversation
corya-akamai
requested review from
bnussman-akamai and
jaalah-akamai
and removed request for
a team
corya-akamai
force-pushed
the
UIE-8074
branch
from
ed86113
to
90bf6e0
Compare
|
Coverage Report: ✅ |
cpathipa
requested review from
cpathipa
and removed request for
jaalah-akamai
| export const StyledValueBox = styled(Box, { | ||
| label: 'StyledValueBox', | ||
| })(({ theme }) => ({ | ||
| '& > button': { | ||
| marginTop: '-5px', | ||
| }, | ||
| '& > div': { | ||
| alignSelf: 'flex-start', | ||
| verticalAlign: 'sub', | ||
| }, | ||
| '& button.MuiButtonBase-root': { | ||
| marginTop: '0', | ||
| }, | ||
| '& button.copy-tooltip': { | ||
| marginTop: '-3px', | ||
| }, | ||
| color: theme.palette.mode === 'dark' ? theme.color.grey8 : theme.color.black, | ||
| display: 'flex', | ||
| padding: '3px 5px', | ||
| })); |
There was a problem hiding this comment.
Could we do something like the following to improve alignment (vertically centered values), make use of flex, and avoid the need for another nested component within the Grid item by replacing the parent of StyledValueBox with:
| export const StyledValueBox = styled(Box, { | |
| label: 'StyledValueBox', | |
| })(({ theme }) => ({ | |
| '& > button': { | |
| marginTop: '-5px', | |
| }, | |
| '& > div': { | |
| alignSelf: 'flex-start', | |
| verticalAlign: 'sub', | |
| }, | |
| '& button.MuiButtonBase-root': { | |
| marginTop: '0', | |
| }, | |
| '& button.copy-tooltip': { | |
| marginTop: '-3px', | |
| }, | |
| color: theme.palette.mode === 'dark' ? theme.color.grey8 : theme.color.black, | |
| display: 'flex', | |
| padding: '3px 5px', | |
| })); | |
| export const StyledGridValue= styled(Grid2, { | |
| label: 'StyledGridValue', | |
| })(({ theme }) => ({ | |
| alignItems: 'center', | |
| color: theme.palette.mode === 'dark' ? theme.color.grey8 : theme.color.black, | |
| display: 'flex', | |
| padding: `0 ${theme.spacing()}`, | |
| })); |
I was seeing some weirdness with the icons existing outside the grid container at really small screen sizes (which is also currently happening), so might need to make some adjustments to this still.
| const readOnlyHostValue = | ||
| database?.hosts?.standby ?? database?.hosts?.secondary ?? ''; | ||
|
|
||
| const readOnlyHost = () => { | ||
| const defaultValue = isLegacy ? '-' : 'not available'; | ||
| const value = readOnlyHostValue ?? defaultValue; | ||
| return ( | ||
| <> | ||
| {value} | ||
| <CopyTooltip | ||
| className={classes.inlineCopyToolTip} | ||
| text={readOnlyHostValue} | ||
| /> |
There was a problem hiding this comment.
I think we'll want the copy tooltip not to render if the readOnlyHostValue is an empty string.
There was a problem hiding this comment.
CI has a typecheck error that I'm not seeing locally. 🤔
There was a problem hiding this comment.
Unrelated to the above, I am also seeing eslint warnings in several files. Can we clean those up before merging this?
The VSCode ESLint extension (if you don't already have it installed) is very useful.
Description 📝
DBaaS GA summary tab refactor. Data remains the same, although the layout is altered.
Changes 🔄
Target release date 🗓️
10/28/24
Preview 📷
How to test 🧪
Prerequisites
Verification steps
As an Author I have considered 🤔
Check all that apply