-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: [M3-8373] - Fix unexpected heading spacing on Account Maintenance page #11099
base: develop
Are you sure you want to change the base?
change: [M3-8373] - Fix unexpected heading spacing on Account Maintenance page #11099
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ confirmed spacing for Account Maintenance in both light/dark modes
thanks Harsh! Left one small comment
@@ -143,11 +144,18 @@ const MaintenanceTable = ({ type }: Props) => { | |||
}; | |||
|
|||
return ( | |||
<> | |||
<Box | |||
className={classes.headingContainer} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like classes.headingContainer
isn't used anywhere else in this file, so we can remove headingContainer
from the useStyles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whenever possible, we try to replace default exports with named exports. This component would be a good candidate.
Description 📝
On the Account Maintenance page, the "Pending" and "Completed" headings have spacing which is inconsistent with the spacing of our headings on other pages.
Changes 🔄
Target release date 🗓️
10/28
Preview 📷
How to test 🧪
Verification steps
localhost:3000/account/maintenance
As an Author I have considered 🤔
Check all that apply