Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change: [M3-8442] - Remove Double border on "Billing & Payment History" table with dark theme. #11111

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

change: [M3-8442] - Remove Double border on "Billing & Payment History" table with dark theme. #11111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0d4f8b9
change: [M3-8442] - Remove Double border on "Billing & Payment Histor…
hasyed-akamai Oct 16, 2024
581e789
Added changeset: Remove Double border on Billing
hasyed-akamai Oct 16, 2024
b8b333f
Merge branch 'develop' into feature/M3-8442-double-border-on-billing-…
hasyed-akamai Oct 17, 2024
c60b2df
Remove the use of useTheme Hook
hasyed-akamai Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-11111-changed-1729082750525.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Changed
---

Remove Double border on "Billing & Payment History" table with dark theme. ([#11111](https://github.com/linode/manager/pull/11111))
9 changes: 8 additions & 1 deletion .../manager/src/features/Billing/BillingPanels/BillingActivityPanel/BillingActivityPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,14 @@ export const BillingActivityPanel = React.memo((props: Props) => {

return (
<Grid data-qa-billing-activity-panel xs={12}>
<Paper variant="outlined">
<Paper
sx={(theme) => ({
border:
theme.name === 'light'
? `1px solid ${theme.borderColors.divider}`
: 0,
})}
>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this solves the root problem, it just overrides it. I would undo this change and I'll point out what should change.

<StyledBillingAndPaymentHistoryHeader
className={classes.headerContainer}
>
Expand Down