Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [M3-8746] – Move inputMaxWidth into Theme #11116

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

dwiley-akamai
Copy link
Contributor

Description πŸ“

Follow-up to #11092 -- move inputMaxWidth into Theme so we can reference it as theme.inputMaxWidth as opposed to exporting & importing the inputMaxWidth variable

Changes πŸ”„

  • Add inputMaxWidth to Theme
  • Replace uses of inputMaxWidth variable in components with theme.inputMaxWidth

Target release date πŸ—“οΈ

10/28/24

How to test πŸ§ͺ

Verification steps

Confirm there are no width regressions for the VPC and Security sections in the Linode Create flow

As an Author I have considered πŸ€”

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/Improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

@dwiley-akamai dwiley-akamai self-assigned this Oct 16, 2024
@dwiley-akamai dwiley-akamai requested a review from a team as a code owner October 16, 2024 21:31
@dwiley-akamai dwiley-akamai requested review from bnussman-akamai and coliu-akamai and removed request for a team October 16, 2024 21:31
Copy link

github-actions bot commented Oct 16, 2024

Coverage Report: βœ…
Base Coverage: 87.06%
Current Coverage: 87.06%

Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

βœ… confirmed no VPC width regressions
βœ… confirmed no Security width regressions in the skeleton

Thanks Dajahi! Would we need a changeset for the manager package?

@coliu-akamai coliu-akamai added the Add'tl Approval Needed Waiting on another approval! label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Add'tl Approval Needed Waiting on another approval! Modularization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants