fix: Dark Mode style regressions #11123
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
added
Bug
bnussman-akamai
requested review from
cpathipa and
hkhalil-akamai
and removed request for
a team
bnussman-akamai
commented
Oct 17, 2024
| @@ -25,6 +25,7 @@ | |||
| "@lukemorales/query-key-factory": "^1.3.4", | |||
| "@mui/icons-material": "^5.14.7", | |||
| "@mui/material": "^5.14.7", | |||
| "@mui/utils": "^5.14.7", | |||
There was a problem hiding this comment.
This does add a new explicit dependency but I don't think it's doing much harm. It is already installed by yarn because @mui/material depends on it
If anyone prefers we use a custom deepMerge like we did previously, happy to discuss
There was a problem hiding this comment.
I think that's great cause we already importing this in many places, so another step closer to PNPM
There was a problem hiding this comment.
Oh wow. Good call. I didn't even realize that!
abailly-akamai
approved these changes
Oct 17, 2024
| @@ -25,6 +25,7 @@ | |||
| "@lukemorales/query-key-factory": "^1.3.4", | |||
| "@mui/icons-material": "^5.14.7", | |||
| "@mui/material": "^5.14.7", | |||
| "@mui/utils": "^5.14.7", | |||
There was a problem hiding this comment.
I think that's great cause we already importing this in many places, so another step closer to PNPM
| @@ -107,4 +108,4 @@ declare module '@mui/material/styles/createTheme' { | |||
|
|
|||
| export const inputMaxWidth = _inputMaxWidth; | |||
| export const light = createTheme(lightTheme); | |||
| export const dark = createTheme(lightTheme, darkTheme); | |||
| export const dark = createTheme(deepmerge(lightTheme, darkTheme)); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
@mui/systemimports #11081createThemeRelated Docs 📖
See https://v5.mui.com/material-ui/customization/theming/#createtheme-options-args-theme
I think the key point is
Calling
createThemebefore merging the raw options has implications that I didn't foresee. CallingcreateThemewith the theme options merged first fixes the issues we are seeingScreenshots of the Issues 📷
How to test 🧪
As an Author I have considered 🤔