Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [UIE-8196] - DBaaS create encourage users to add IP allow_list #11124

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

corya-akamai
Copy link
Contributor

@corya-akamai corya-akamai commented Oct 17, 2024

Description 📝

DBaaS create encourage users to add IP allow_list

Changes 🔄

  • Access Controls are now wrapped in a radio button group
  • User has to explicitly select "None" when adding allow lists
  • Add disable prop to MultipleIPInput component to disable all actions with tests
  • Refactored the AccessControl from the create page for increased modularity, added tests.

Target release date 🗓️

10/28/24

Preview 📷

Before After

|
Screenshot 2024-10-17 at 4 23 20 PM
|
Screenshot 2024-10-17 at 4 22 31 PM
|
Screenshot 2024-10-17 at 4 26 35 PM

How to test 🧪

Prerequisites

  • Managed Databases account access
  • dbaasV2 flag enabled

Reproduction steps

  • Got to the create page

Verification steps

  • There is a radio group option

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@corya-akamai corya-akamai requested a review from a team as a code owner October 17, 2024 20:33
@corya-akamai corya-akamai requested review from carrillo-erik and jaalah-akamai and removed request for a team October 17, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant