Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for Block Storage Encryption #1623

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Added support for Block Storage Encryption #1623

wants to merge 2 commits into from

Conversation

ezilber-akamai
Copy link
Contributor

@ezilber-akamai ezilber-akamai commented Oct 17, 2024 •
edited
Loading

📝 Description

Added support for Block Storage Encryption across the following endpoints:

  • POST /volumes
  • GET /volumes
  • GET /volumes/<volume_id>
  • GET /regions
  • GET /regions/<region_id>
  • GET /linode/instances
  • GET /linode/instances/<linode_id>
  • GET /account

✔️ How to Test

Integration Tests

  • make PKG_NAME=linode/instance ARGS="-run TestAccDataSourceInstances_withBlockStorageEncryption" int-test
  • make PKG_NAME=linode/volume ARGS="-run TestAccDataSourceVolume_withBlockStorageEncryption" int-test
  • make PKG_NAME=linode/volume ARGS="-run TestAccDataSourceVolume_basic" int-test

NOTE: This PR cannot be merged until the next linodego release.
TODO: Remove replace in go.mod

@ezilber-akamai ezilber-akamai requested a review from a team as a code owner October 17, 2024 14:25
@ezilber-akamai ezilber-akamai requested review from jriddle-linode and ykim-1 and removed request for a team October 17, 2024 14:25
@ezilber-akamai ezilber-akamai added new-feature for new features in the changelog. do-not-merge PRs that should not be merged until the commented issue is resolved labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jriddle-linode jriddle-linode Awaiting requested review from jriddle-linode jriddle-linode is a code owner automatically assigned from linode/dx

@ykim-1 ykim-1 Awaiting requested review from ykim-1 ykim-1 is a code owner automatically assigned from linode/dx

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
do-not-merge PRs that should not be merged until the commented issue is resolved new-feature for new features in the changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ezilber-akamai