ci: add allow-unsafe-pr-checkout option to checkout steps - #228
Open
asterwyx wants to merge 1 commit into
Open
Conversation
Add allow-unsafe-pr-checkout: true to both source and dest repository checkout steps in synchronize workflow. 在同步工作流的源仓库和目标仓库 checkout 步骤中添加 allow-unsafe-pr-checkout: true 配置项。 Log: 同步工作流checkout步骤添加unsafe-pr-checkout选项 Influence: 允许在PR事件触发时安全检出仓库，确保同步流程正常运行。
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe synchronization workflow now passes allow-unsafe-pr-checkout: true to both source and destination checkout actions, allowing repository checkout to proceed correctly when the workflow is triggered by pull request events. Sequence diagram for PR-triggered repository synchronizationsequenceDiagram
participant Workflow as SynchronizeWorkflow
participant SourceRepo as SourceRepository
participant DestRepo as DestinationRepository
Workflow->>SourceRepo: actions/checkout@v3 allow-unsafe-pr-checkout: true
SourceRepo-->>Workflow: Source checkout
Workflow->>DestRepo: actions/checkout@v3 allow-unsafe-pr-checkout: true
DestRepo-->>Workflow: Destination checkout
Workflow->>Workflow: rsync
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path=".github/workflows/synchronize-to-dtk6.yml" line_range="36" />
<code_context>
path: 'source'
repository: ${{ inputs.source_repo }}
fetch-depth: 0
+ allow-unsafe-pr-checkout: true
- name: Checkout dest repository ${{ inputs.dest_repo }}
</code_context>
<issue_to_address>
**issue (bug_risk):** `actions/checkout@v3` does not define an `allow-unsafe-pr-checkout` input, so the runner ignores these settings and only emits an unexpected-input warning; the workflow therefore does not gain the PR checkout behavior described in the change.
**Triggers:** When the synchronization workflow depends on this option to checkout a pull-request ref.
**Suggested fix:** Use an actions/checkout version and configuration that explicitly supports the required PR checkout behavior, or remove this unsupported input and implement the supported equivalent.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| path: 'source' | ||
| repository: ${{ inputs.source_repo }} | ||
| fetch-depth: 0 | ||
| allow-unsafe-pr-checkout: true |
There was a problem hiding this comment.
issue (bug_risk): actions/checkout@v3 does not define an allow-unsafe-pr-checkout input, so the runner ignores these settings and only emits an unexpected-input warning; the workflow therefore does not gain the PR checkout behavior described in the change.
Triggers: When the synchronization workflow depends on this option to checkout a pull-request ref.
Suggested fix: Use an actions/checkout version and configuration that explicitly supports the required PR checkout behavior, or remove this unsupported input and implement the supported equivalent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add allow-unsafe-pr-checkout: true to both source and dest repository
checkout steps in synchronize workflow.
在同步工作流的源仓库和目标仓库 checkout 步骤中添加
allow-unsafe-pr-checkout: true 配置项。
Log: 同步工作流checkout步骤添加unsafe-pr-checkout选项
Influence: 允许在PR事件触发时安全检出仓库，确保同步流程正常运行。
Summary by Sourcery
Enable pull request checkout support in the synchronization workflow for both source and destination repositories.
Enhancements:
CI: