Updated README #236
Closed
Updated README #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcalixte
reviewed
Nov 5, 2023
Comment on lines
-28
to
+31
| ninja -C debian/build | ||
| ninja -C debian/build install | ||
|
|
||
| ```shell | ||
| meson build debian/build | ||
| meson compile -C debian/build | ||
| meson install -C debian/build | ||
| ``` |
There was a problem hiding this comment.
Is there a reason you removed the existing commands and replaced them? The new commands are also duplicative and incorrect. For me, meson build debian/build generates errors but this is also duplicative of the command that works from step 1. This is on systems with meson version 0.61.2. Also, meson compile and meson install both just run the ninja commands from the previous commands that were in the documentation. Same for the uninstall steps that come after this. I don't understand the need to obfuscate those commands.
Apologies if there's any confusion on my part.
|
The 'deprecated_warnings' is a typo, which is why you were getting this error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: meson.build:4:0: ERROR: Unknown options: "deprecated_warnings"