Skip to content

Commit

Permalink
cs_themes: Don't mess with the stack switcher's sensitivity.
Browse files Browse the repository at this point in the history 
This is leftover from when we didn't hide the switcher in simple
mode, but merely made it insensitive to clicks.

We hide it now, there's no need for more.

Fixes #12347
  • Loading branch information
@mtwebster
mtwebster committed Aug 9, 2024
1 parent 1f5bb22 commit da63f90
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions files/usr/share/cinnamon/cinnamon-settings/modules/cs_themes.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -547,10 +547,8 @@ def set_mode(self, mode, startup=False):

if mode == "simplified":
switcher_widget.set_opacity(0.0)
switcher_widget.set_sensitive(False)
else:
switcher_widget.set_opacity(1.0)
switcher_widget.set_sensitive(True)

self.sidePage.stack.set_visible_child_full(mode, transition)

Expand Down

2 comments on commit da63f90

@anaximeno
Copy link
Contributor

@anaximeno anaximeno commented on da63f90 Aug 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mtwebster you still could click the invisible stack switcher at the top for the tests I made, and it'll change the section in the themes module, I've sent as a potential fix before #12300 which enables the stack switcher when leaving out the themes module. I'm not sure if it's the best solution in your view, but it avoids the potential issue of clicking the invisible switcher while in the themes module.

@mtwebster
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah dang I knew this, thought I'd merged it and it was still acting up. I'll have a look now. Thanks

Please sign in to comment.