-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add System Monitor to right click panel when one is found #12134
base: master
Are you sure you want to change the base?
Conversation
Also for reference a similar PR I made was declined before which had hard-coded options which was less ideal #10352 |
Speaking of muscle memory, what about Cinnamon users' muscle memories? :) Maybe putting it in troubleshooting would be safer? I know I use System Settings here constantly, others probably do as well - this makes it a bit crowded there. |
and update system settings to use symbolic icon
@mtwebster Done, fair compromise Pushed changes, and squashed the commits |
This would be a very useful feature for those coming from Windows! It would be more intuitive than modifying the keyboard shortcuts, since in Cinnamon Ctrl+Alt+Delete is not used to launch the system monitor |
menu.addMenuItem(new PopupMenu.PopupSeparatorMenuItem()); // separator line | ||
menu.addMenuItem(menu.troubleshootItem); | ||
|
||
this.addMenuItem(new SettingsLauncher(_("System Settings"), "", "preferences-desktop")); | ||
this.addMenuItem(new SettingsLauncher(_("System Settings"), "", "system-run", "cinnamon-settings")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although working with the other icon themes I tested, the system-run icon presents something like a play icon for the breeze icon theme, so it might not be the best suited for System Settings there.
This uses category heuristics similar to how we find Terminals for Preferred Applications setting
Also update system settings to use symbolic icon.
Purpose is quick access, feature parity with other desktop environments as a sane default for muscle memory
Forum Discussion and Poll:
https://forums.linuxmint.com/viewtopic.php?t=416628