Use single rendering script for all variations #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the effort. I want to hold off a bit on merging this. Currently working on some updating to the themes and repos. It will likely change some of the assets that are being used and some can likely be shared between gtk3 and 4 versions to cut down on the moving parts even more. |
|
So, should I keep this PR open? Or close it and create a new PR with updated master? |
|
You can keep it open. It may still end up working as is. I'll take a look back at it later on. |
|
Ok. Thanks for the hard work. |
- uses single render-assets.sh for all variations - single rendering script takes care of all assets used in gtk variations and xfwm variations - reduces repo size and better automation - No need to include .png files with repo as they can be generated during building deb packaging - better rendering of assets for new themes like gtk-4.0 - original rendering scripts has been kept back but can be removed
hsbasu
force-pushed
the
use-single-rendering-script
branch
from
f973e82
to
c03d709
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
used in gtk variations and xfwm variations
they can be generated during building deb packaging