refactor: simplify

linz · Aug 14, 2024 · 239c19b · 239c19b
1 parent bd5f99a
commit 239c19b
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/templates/common/exit.handler.yaml b/templates/common/exit.handler.yaml
@@ -30,13 +30,14 @@ spec:
           {{= inputs.parameters.workflow_parameters }}.forEach((pair) => (parameters[pair.name] = pair.value));
 
           function guessWorkflowGroup() {
-            if (parameters['source'] === undefined) {
+            const source = parameters['source'];
+            if (!source) {
               return 'unknown';
             }
-            if (parameters['source'].startsWith('s3://linz-topographic-upload')) {
+            if (source.startsWith('s3://linz-topographic-upload')) {
               return 'land';
             }
-            if (parameters['source'].startsWith('s3://linz-hydrographic-upload')) {
+            if (source.startsWith('s3://linz-hydrographic-upload')) {
               return 'sea';
             }
             return 'unknown';