feat: add write permissions for basemaps buckets BM-822 #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blacha
approved these changes
Aug 23, 2023
3 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 23, 2023
#### Description Fixes bucket permissions for `basemaps-imagery-import-cogify`. #### Intention Does what PR #159 aimed to do, but did not work, as multiple comma separated sources for role config files were not supported. #### Checklist *If not applicable, provide explanation of why.* - [ ] Tests updated - [ ] Docs updated - [x] Issue linked in title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds ability for
basemaps-imagery-import-cogifyworkflow to write to Basemaps buckets.Intention
Testing was done outputting too
s3://linz-imagery-artifactsso it was missed that the workflow did not have write permission tos3://linz-basemaps.Checklist
If not applicable, provide explanation of why.