Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: publish odr historic imagery workflow TDE-1184 #595

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

MDavidson17
Copy link
Contributor

@MDavidson17 MDavidson17 commented May 22, 2024

Motivation

the target path automation is not implemented for historic imagery as required information is missing from the stac metadata (survey number).

To continue to publish historic imagery this workflow has been created as a workaround allowing data managers to specify the target path and bypass the automation.

Modification

A second workflow has been created called publish-odr-historic-imagery, which is a copy of publish-odr with the following changes:

  • Added target workflow parameter
  • Removed the generate-path task and replaced it with the workflow parameter

This has been kept separate from the publish-odr workflow as this functionality should be reserved only for historic imagery cases.

Checklist

If not applicable, provide explanation of why.

@MDavidson17 MDavidson17 marked this pull request as ready for review May 22, 2024 02:30
@MDavidson17 MDavidson17 requested review from a team as code owners May 22, 2024 02:30
Co-authored-by: paulfouquet <86932794+paulfouquet@users.noreply.github.com>
paulfouquet
paulfouquet previously approved these changes May 22, 2024
workflows/raster/README.md Outdated Show resolved Hide resolved
workflows/raster/README.md Outdated Show resolved Hide resolved
workflows/raster/README.md Outdated Show resolved Hide resolved
workflows/raster/README.md Outdated Show resolved Hide resolved
Co-authored-by: Victor Engmark <vengmark@linz.govt.nz>
@MDavidson17 MDavidson17 requested a review from l0b0 May 23, 2024 23:30
- name: target_bucket_name
value: ''
enum:
- 'nz-elevation'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not allow people to publish historical imagery into the elevation bucket.

@paulfouquet paulfouquet marked this pull request as draft June 6, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants