-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: publish odr historic imagery workflow TDE-1184 #595
Draft
MDavidson17
wants to merge
7
commits into
master
Choose a base branch
from
feat/publish-odr-hi
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
workaround for historic imagery
paulfouquet
reviewed
May 22, 2024
paulfouquet
reviewed
May 22, 2024
Co-authored-by: paulfouquet <86932794+paulfouquet@users.noreply.github.com>
paulfouquet
previously approved these changes
May 22, 2024
l0b0
reviewed
May 23, 2024
l0b0
reviewed
May 23, 2024
Co-authored-by: Victor Engmark <vengmark@linz.govt.nz>
l0b0
approved these changes
May 23, 2024
paulfouquet
approved these changes
May 27, 2024
blacha
reviewed
May 27, 2024
- name: target_bucket_name | ||
value: '' | ||
enum: | ||
- 'nz-elevation' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not allow people to publish historical imagery into the elevation bucket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
the target path automation is not implemented for historic imagery as required information is missing from the stac metadata (survey number).
To continue to publish historic imagery this workflow has been created as a workaround allowing data managers to specify the target path and bypass the automation.
Modification
A second workflow has been created called
publish-odr-historic-imagery
, which is a copy ofpublish-odr
with the following changes:target
workflow parametergenerate-path
task and replaced it with the workflow parameterThis has been kept separate from the
publish-odr
workflow as this functionality should be reserved only for historic imagery cases.Checklist
If not applicable, provide explanation of why.