feat: log workflowGroup from the exit-handler TDE-1230 #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulfouquet
requested review from
l0b0,
blacha,
amfage,
MDavidson17 and
Wentao-Kuang
|
Converting to draft while adding tests |
blacha
reviewed
Aug 19, 2024
| } | ||
|
|
||
| describe('exit handler script template', () => { | ||
| it('should log workflow status and parameters', () => { |
There was a problem hiding this comment.
it would be good to use the built in test stubber her rather than overwriting the logger
blacha
reviewed
Aug 19, 2024
templates/common/exit.handler.yml
Outdated
| @@ -29,12 +29,27 @@ spec: | |||
| let parameters = {}; | |||
| {{= inputs.parameters.workflow_parameters }}.forEach((pair) => (parameters[pair.name] = pair.value)); | |||
|
|
|||
| function guessWorkflowGroup() { | |||
| const source = parameters['source']; | |||
| if (!source) { | |||
There was a problem hiding this comment.
safer to be typeof source !== 'string' as !1 is false then would error the line below with 1.startsWith
amfage
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It is easier to maintain the workflow group (
landorsea) from the exit handler than from elasticsearch watchers.Modification
workflowGroupbased on the source bucketChecklist