This repository has been archived by the owner on Jul 11, 2019. It is now read-only.
Hashing sensible information in cookies, request_url and referer.
#494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def _url_filter(self, url): | ||
| if url is not None: | ||
| url = re.sub(r'(/welcome/[^/]+/)([0-9a-f]+)(?=/|\?|$)', | ||
| lambda m: m.group(1) + self.hash_func(m.group(2)).hexdigest(), |
There was a problem hiding this comment.
This cuts off the part after the welcome code. Is this intended?
There was a problem hiding this comment.
What make you think so?
There was a problem hiding this comment.
My bad, I misunderstood what re.sub does.
|
LGTM. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added hashing of requestlog
adhocracy_logincookie with a hash of it.request_urlandrefererwith a hash of it.