This repository has been archived by the owner on Jul 11, 2019. It is now read-only.
Fix Python setup. #968
Open
Fix Python setup. #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Python setup was broken when it actually downloaded, since the last line in the bootstrap removes the pkg_resources module from sys.modules and we tried to reload it. While we're at it, remove insecure and slow HTTP downloads in favor of bringing the file with us.
phihag
added a commit
that referenced
this pull request
Sep 11, 2015
Apart from taking quite a while to build and being horrifically insecure (by accident, we found out that we could have been executing arbitary Python code downloaded via HTTP from a spammer - see ##968) - the custom Python version does not build anymore, despite numerous bugfixes. Even after fixing our code, collective.recipe.cmmi 0.5 cannot be built these days because of missing dependencies. ALso, the very error message is broken: Got collective.recipe.cmmi 0.5. While: Installing. Getting section readline. Initializing section readline. Installing recipe collective.recipe.cmmi. An internal error occured due to a bug in either zc.buildout or in a recipe being used: Traceback (most recent call last): File "/home/phihag/adhocracy_buildout/python/eggs/zc.buildout-1.4.4-py2.7.egg/zc/buildout/buildout.py", line 1683, in main getattr(buildout, command)(args) File "/home/phihag/adhocracy_buildout/python/eggs/zc.buildout-1.4.4-py2.7.egg/zc/buildout/buildout.py", line 439, in install [self[part]['recipe'] for part in install_parts] File "/home/phihag/adhocracy_buildout/python/eggs/zc.buildout-1.4.4-py2.7.egg/zc/buildout/buildout.py", line 987, in __getitem__ options._initialize() File "/home/phihag/adhocracy_buildout/python/eggs/zc.buildout-1.4.4-py2.7.egg/zc/buildout/buildout.py", line 1071, in _initialize recipe_class = _install_and_load(reqs, 'zc.buildout', entry, buildout) File "/home/phihag/adhocracy_buildout/python/eggs/zc.buildout-1.4.4-py2.7.egg/zc/buildout/buildout.py", line 1027, in _install_and_load allow_hosts=buildout._allow_hosts File "/home/phihag/adhocracy_buildout/python/eggs/zc.buildout-1.4.4-py2.7.egg/zc/buildout/easy_install.py", line 800, in install return installer.install(specs, working_set) File "/home/phihag/adhocracy_buildout/python/eggs/zc.buildout-1.4.4-py2.7.egg/zc/buildout/easy_install.py", line 662, in install [requirement] = err ValueError: too many values to unpack Therefore, simply install PIL instead of a custom Python build.
|
|
|
Apart from fixing/updating boostrap, there is no need to force the custom python build, we could also use virtuelenv as a install option. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Python setup was broken when it actually downloaded, since the last line in the bootstrap removes the pkg_resources module from sys.modules and we tried to reload it.
While we're at it, remove insecure and slow HTTP downloads in favor of bringing the file with us.