Heredoc append #18
Merged
Heredoc append #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 docs(heredoc.c): update function description for combine_tokens 🐛 fix(heredoc.c): fix indentation in combine_heredoc function 📝 docs(index.c): update function description for check_double_ops 🐛 fix(index.c): fix indentation in check_double_ops function 🐛 fix(index.c): fix indentation in check_tokens function 🐛 fix(main.c): uncomment check_tokens function call
🐛 fix(tasks.json): remove DEBUG=1 flag from make command 🐛 fix(heredoc.c): fix memory allocation and null termination bug in ft_strjoin_space function ✨ feat(heredoc.c): combine heredoc token with string token for execution 🐛 fix(index.c): fix offset bug in check_heredoc function 🐛 fix(main.c): fix prompt string and function calls in loop function
🐛 fix(index.c): fix decrementing index in check_heredoc function
🐛 fix(index.c): fix incorrect index after decrementing in decrement_index function 🐛 fix(print_vector.c): add missing case for A_REDIRECT type in extra_types_short function 🐛 fix(main.c): remove newline character before minishell prompt in readline function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heredocs are now merging before execution. The checking and combining happens at the same time. I've put a warning in to not use the found items after the combining but I thought it would be wise to mention it again.
😄