Skip to content

Require exp when verifying access tokens #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SashaMIT wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Require exp when verifying access tokens #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88d0b5c
Require exp when verifying access tokens
SashaMIT Aug 19, 2026
8b7b018
Require jwt >= 2.3.0 for required_claims
SashaMIT Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ PATH
livekit-server-sdk (1.0.0)
faraday (>= 2.0, < 3.0)
google-protobuf (~> 4.30, >= 4.30.2)
jwt (>= 2.2.3, < 3.0)
jwt (>= 2.3.0, < 3.0)
twirp (~> 1.13, >= 1.13.1)

GEM
Expand Down
10 changes: 9 additions & 1 deletion lib/livekit/token_verifier.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,15 @@ def initialize(api_key: nil, api_secret: nil)
end

def verify(token)
decoded_token = JWT.decode(token, @api_secret, true, algorithm: AccessToken::SIGNING_ALGORITHM)
decoded_token = JWT.decode(
token,
@api_secret,
true,
{
algorithm: AccessToken::SIGNING_ALGORITHM,
required_claims: ["exp"],

@frostbyte73 frostbyte73 Aug 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

required_claims landed in ruby-jwt v2.3.0 - Gemfile.lock needs to bump the minimum from v2.2.3

},
)
decoded = decoded_token.first
if decoded["iss"] != @api_key
raise "Invalid issuer"
Expand Down
2 changes: 1 addition & 1 deletion livekit_server_sdk.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Gem::Specification.new do |spec|

spec.add_dependency "faraday", ">= 2.0", "< 3.0"
spec.add_dependency "google-protobuf", "~> 4.30", ">= 4.30.2"
spec.add_dependency "jwt", ">= 2.2.3", "< 3.0"
spec.add_dependency "jwt", ">= 2.3.0", "< 3.0"
spec.add_dependency "twirp", "~> 1.13", ">= 1.13.1"

# For more information and examples about making a new gem, checkout our
Expand Down
12 changes: 12 additions & 0 deletions spec/livekit/token_verifier_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,18 @@
expect(grant.attributes["mykey"]).to eq("myvalue")
end

it "fails when exp is missing" do
payload = {
"iss" => TEST_KEY,
"sub" => "user",
"nbf" => Time.now.to_i - 5,
"video" => { "roomJoin" => true, "room" => "testroom" },
}
jwt = JWT.encode(payload, TEST_SECRET, "HS256")
v = described_class.new(api_key: TEST_KEY, api_secret: TEST_SECRET)
expect { v.verify(jwt) }.to raise_error(JWT::MissingRequiredClaim)
end

it "fails on expired tokens" do
token = LiveKit::AccessToken.new(api_key: TEST_KEY, api_secret: TEST_SECRET,
identity: "test_identity", ttl: -10)
Expand Down
Loading