Bump zeebe-io/backport-action from 1.4.0 to 2.4.1 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [zeebe-io/backport-action](https://github.com/zeebe-io/backport-action) from 1.4.0 to 2.4.1. - [Release notes](https://github.com/zeebe-io/backport-action/releases) - [Commits](korthout/backport-action@v1.4.0...v2.4.1) --- updated-dependencies: - dependency-name: zeebe-io/backport-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
the
dependencies
puckipedia
pushed a commit
that referenced
this pull request
Feb 26, 2024
GitHub Pull Request: #4 Bump zeebe-io/backport-action from 1.4.0 to 2.4.1 Bumps [zeebe-io/backport-action](https://github.com/zeebe-io/backport-action) from 1.4.0 to 2.4.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/zeebe-io/backport-action/releases">zeebe-io/backport-action's releases</a>.</em></p> <blockquote> <h2>Backport-action v2.4.1</h2> <h2>What's Changed</h2> <ul> <li>fix: rendering templates due to missing brackets by <a href="https://github.com/jschmid1"><code>@jschmid1</code></a> in <a href="https://redirect.github.com/korthout/backport-action/pull/410">korthout/backport-action#410</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/korthout/backport-action/compare/v2.4.0...v2.4.1">https://github.com/korthout/backport-action/compare/v2.4.0...v2.4.1</a></p> <h2>Backport-action v2.4.0</h2> <h2>What's Changed</h2> <p>The new <code>${pull_description}</code> <a href="https://github.com/korthout/backport-action#placeholders">placeholder</a> allows you to copy the original pull request's description to the backported PR. This can be helpful if the body contains links to ticketing systems, related documents etc.</p> <ul> <li>Add <code>${pull_description}</code> placeholder by <a href="https://github.com/jschmid1"><code>@jschmid1</code></a> in <a href="https://redirect.github.com/korthout/backport-action/pull/409">korthout/backport-action#409</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/korthout/backport-action/compare/v2.3.0...v2.4.0">https://github.com/korthout/backport-action/compare/v2.3.0...v2.4.0</a></p> <h2>Backport-action v2.3.0</h2> <h2>What's Changed</h2> <p>This release introduces a new <code>created_pull_numbers</code> <a href="https://github.com/korthout/backport-action#outputs">output</a> that you can use in successive steps. For example, label the created pull requests or <a href="https://redirect.github.com/korthout/backport-action/issues/403">trigger your CI on the created pull requests</a>. Massive thanks to <a href="https://github.com/GuyAv46"><code>@GuyAv46</code></a> for this contribution.</p> <ul> <li>Add <code>created_pull_numbers</code> output by <a href="https://github.com/GuyAv46"><code>@GuyAv46</code></a> in <a href="https://redirect.github.com/korthout/backport-action/pull/404">korthout/backport-action#404</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/GuyAv46"><code>@GuyAv46</code></a> made their first contribution in <a href="https://redirect.github.com/korthout/backport-action/pull/404">korthout/backport-action#404</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/korthout/backport-action/compare/v2.2.0...v2.3.0">https://github.com/korthout/backport-action/compare/v2.2.0...v2.3.0</a></p> <h2>Backport-action v2.2.0</h2> <h2>What's Changed</h2> <p>This release introduces a new <a href="https://github.com/korthout/backport-action#experimental"><code>experimental</code></a> input that you can use to configure experimental features. We encourage everyone to try them out and share feedback.</p> <p>As a first experimental feature, this release adds <a href="https://github.com/korthout/backport-action#detect_merge_method"><code>detect_merge_method</code></a>. When enabled, it cherry-picks the resulting commits based on the detected merge method. Give it a try if you're using the <code>Squash and merge</code> or <code>Rebase and merge</code> merge method for your pull requests, and please <a href="https://github.com/korthout/backport-action/issues/new?labels=bug&template=bug_report.md">report any issues</a> you encounter.</p> <p>To enable merge method detection add the following to your backport workflow:</p> <pre lang="yaml"><code>using: korthout/backport-action@v2 with: experimental: > { "detect_merge_method": true } </code></pre> <p>A special shoutout and heartfelt thanks to <a href="https://github.com/jschmid1"><code>@jschmid1</code></a> for their outstanding contribution to the <code>detect_merge_method</code> feature!</p> <ul> <li>Detect squash and rebase merge methods by <a href="https://github.com/jschmid1"><code>@jschmid1</code></a> in <a href="https://redirect.github.com/korthout/backport-action/pull/399">korthout/backport-action#399</a></li> </ul> <h2>Documentation</h2> <ul> <li>Avoid loop in backport by comment usage example by <a href="https://github.com/jschmid1"><code>@jschmid1</code></a> in <a href="https://redirect.github.com/korthout/backport-action/pull/400">korthout/backport-action#400</a></li> <li>Align event type in usage example by <a href="https://github.com/chillleader"><code>@chillleader</code></a> in <a href="https://redirect.github.com/korthout/backport-action/pull/401">korthout/backport-action#401</a></li> </ul> <h2>Updated Dependencies</h2> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/korthout/backport-action/commit/e8161d6a0dbfa2651b7daa76cbb75bc7c925bbf3"><code>e8161d6</code></a> dist: release 2.4.1</li> <li><a href="https://github.com/korthout/backport-action/commit/2740887b8d9fb88f6b5760681af4ec8e6037083c"><code>2740887</code></a> dist: build new version</li> <li><a href="https://github.com/korthout/backport-action/commit/ec07f3ebed7bed80b0bca599f62d80696da9d9a0"><code>ec07f3e</code></a> Merge pull request <a href="https://redirect.github.com/zeebe-io/backport-action/issues/410">#410</a> from jschmid1/fix/template-rendering</li> <li><a href="https://github.com/korthout/backport-action/commit/75b4a31e0ebd542d32b841976d44f5ea206e51c9"><code>75b4a31</code></a> fix: rendering templates due to missing brackets</li> <li><a href="https://github.com/korthout/backport-action/commit/4e7a9017281328af5f90da75811038d809578573"><code>4e7a901</code></a> dist: release 2.5.0-SNAPSHOT</li> <li><a href="https://github.com/korthout/backport-action/commit/79b9f245a4132c5bf4bca01c7526cfea24059c03"><code>79b9f24</code></a> dist: release 2.4.0</li> <li><a href="https://github.com/korthout/backport-action/commit/8546a417ed6a4c0a7296b6373bf5ba65937772bb"><code>8546a41</code></a> Merge pull request <a href="https://redirect.github.com/zeebe-io/backport-action/issues/409">#409</a> from jschmid1/feat/pull_description_body</li> <li><a href="https://github.com/korthout/backport-action/commit/29fedd9c934e40c0070c8c8d9b8843f6d1b26329"><code>29fedd9</code></a> docs: reorder the placeholders alphanumerically</li> <li><a href="https://github.com/korthout/backport-action/commit/258a18ba7f3c1e690a9e16739faf469d021d43b9"><code>258a18b</code></a> docs: align pull_description placeholder text</li> <li><a href="https://github.com/korthout/backport-action/commit/ba84c7a0105bf08e022a22ccfc40f247c9ceaf24"><code>ba84c7a</code></a> feat: add <code>pull_description</code> to placeholders</li> <li>Additional commits viewable in <a href="https://github.com/zeebe-io/backport-action/compare/v1.4.0...v2.4.1">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Patch-set: 1 Change-id: I50ce6fdd454d27d4fa55c26d233f956fd9a4627d Subject: Bump zeebe-io/backport-action from 1.4.0 to 2.4.1 Branch: refs/heads/main Status: new Topic: Commit: feff3b1 Tag: autogenerated:gerrit:newPatchSet Groups: feff3b1 Private: false Work-in-progress: false
|
Superseded by #6. |
dependabot
bot
deleted the
dependabot/github_actions/zeebe-io/backport-action-2.4.1
branch
lf-
added a commit
that referenced
this pull request
Apr 28, 2024
this was caused by the use of std::chrono::duration::max() which gets
multiplied by some ratio to calculate nanoseconds to wait. then, it
explodes because that is a signed integer overflow. this was definitely
a bug.
error below:
/nix/store/fdiknsmnnczx6brsbppyljcs9hqckawk-gcc-12.3.0/include/c++/12.3.0/bits/chrono.h:225:38: runtime error: signed integer overflow: 9223372036854775807 * 1000000 cannot be represented in type 'long'
#0 0x736d376b2b69 in std::chrono::duration<long, std::ratio<1l, 1000000000l>> std::chrono::__duration_cast_impl<std::chrono:
:duration<long, std::ratio<1l, 1000000000l>>, std::ratio<1000000l, 1l>, long, false, true>::__cast<long, std::ratio<1l, 1000l>>(
std::chrono::duration<long, std::ratio<1l, 1000l>> const&) /nix/store/fdiknsmnnczx6brsbppyljcs9hqckawk-gcc-12.3.0/include/c++/12
.3.0/bits/chrono.h:225:38
#1 0x736d376b2b69 in std::enable_if<__is_duration<std::chrono::duration<long, std::ratio<1l, 1000000000l>>>::value, std::chr
ono::duration<long, std::ratio<1l, 1000000000l>>>::type std::chrono::duration_cast<std::chrono::duration<long, std::ratio<1l, 10
00000000l>>, long, std::ratio<1l, 1000l>>(std::chrono::duration<long, std::ratio<1l, 1000l>> const&) /nix/store/fdiknsmnnczx6brs
bppyljcs9hqckawk-gcc-12.3.0/include/c++/12.3.0/bits/chrono.h:270:9
#2 0x736d376b2b69 in std::enable_if<__is_duration<std::chrono::duration<long, std::ratio<1l, 1000000000l>>>::value, std::chr
ono::duration<long, std::ratio<1l, 1000000000l>>>::type std::chrono::ceil<std::chrono::duration<long, std::ratio<1l, 1000000000l
>>, long, std::ratio<1l, 1000l>>(std::chrono::duration<long, std::ratio<1l, 1000l>> const&) /nix/store/fdiknsmnnczx6brsbppyljcs9
hqckawk-gcc-12.3.0/include/c++/12.3.0/bits/chrono.h:386:14
#3 0x736d376b2b69 in std::cv_status std::condition_variable::wait_for<long, std::ratio<1l, 1000l>>(std::unique_lock<std::mut
ex>&, std::chrono::duration<long, std::ratio<1l, 1000l>> const&) /nix/store/fdiknsmnnczx6brsbppyljcs9hqckawk-gcc-12.3.0/include/
c++/12.3.0/condition_variable:164:6
#4 0x736d376b1ee9 in std::cv_status nix::Sync<nix::ProgressBar::State, std::mutex>::Lock::wait_for<long, std::ratio<1l, 1000
l>>(std::condition_variable&, std::chrono::duration<long, std::ratio<1l, 1000l>> const&) /home/jade/lix/lix/src/libutil/sync.hh:
65:23
#5 0x736d376b1ee9 in nix::ProgressBar::ProgressBar(bool)::'lambda'()::operator()() const /home/jade/lix/lix/src/libmain/prog
ress-bar.cc:99:27
#6 0x736d36de25c2 in execute_native_thread_routine (/nix/store/a3zlvnswi1p8cg7i9w4lpnvaankc7dxx-gcc-12.3.0-lib/lib/libstdc++
.so.6+0xe05c2)
#7 0x736d36b6b0e3 in start_thread (/nix/store/1zy01hjzwvvia6h9dq5xar88v77fgh9x-glibc-2.38-44/lib/libc.so.6+0x8b0e3) (BuildId
: 287831bffdbdde0ec25dbd021d12bdfc0ab9f5ff)
#8 0x736d36bed5e3 in __clone (/nix/store/1zy01hjzwvvia6h9dq5xar88v77fgh9x-glibc-2.38-44/lib/libc.so.6+0x10d5e3) (BuildId: 28
7831bffdbdde0ec25dbd021d12bdfc0ab9f5ff)
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /nix/store/fdiknsmnnczx6brsbppyljcs9hqckawk-gcc-12.3.0/include/c++/12.3.
0/bits/chrono.h:225:38 in
Change-Id: Ia0303242cdfd5d49385ae9e99718d709625a4633
lf-
added a commit
that referenced
this pull request
May 4, 2024
this was caused by the use of std::chrono::duration::max() which gets
multiplied by some ratio to calculate nanoseconds to wait. then, it
explodes because that is a signed integer overflow. this was definitely
a bug.
error below:
/nix/store/fdiknsmnnczx6brsbppyljcs9hqckawk-gcc-12.3.0/include/c++/12.3.0/bits/chrono.h:225:38: runtime error: signed integer overflow: 9223372036854775807 * 1000000 cannot be represented in type 'long'
#0 0x736d376b2b69 in std::chrono::duration<long, std::ratio<1l, 1000000000l>> std::chrono::__duration_cast_impl<std::chrono:
:duration<long, std::ratio<1l, 1000000000l>>, std::ratio<1000000l, 1l>, long, false, true>::__cast<long, std::ratio<1l, 1000l>>(
std::chrono::duration<long, std::ratio<1l, 1000l>> const&) /nix/store/fdiknsmnnczx6brsbppyljcs9hqckawk-gcc-12.3.0/include/c++/12
.3.0/bits/chrono.h:225:38
#1 0x736d376b2b69 in std::enable_if<__is_duration<std::chrono::duration<long, std::ratio<1l, 1000000000l>>>::value, std::chr
ono::duration<long, std::ratio<1l, 1000000000l>>>::type std::chrono::duration_cast<std::chrono::duration<long, std::ratio<1l, 10
00000000l>>, long, std::ratio<1l, 1000l>>(std::chrono::duration<long, std::ratio<1l, 1000l>> const&) /nix/store/fdiknsmnnczx6brs
bppyljcs9hqckawk-gcc-12.3.0/include/c++/12.3.0/bits/chrono.h:270:9
#2 0x736d376b2b69 in std::enable_if<__is_duration<std::chrono::duration<long, std::ratio<1l, 1000000000l>>>::value, std::chr
ono::duration<long, std::ratio<1l, 1000000000l>>>::type std::chrono::ceil<std::chrono::duration<long, std::ratio<1l, 1000000000l
>>, long, std::ratio<1l, 1000l>>(std::chrono::duration<long, std::ratio<1l, 1000l>> const&) /nix/store/fdiknsmnnczx6brsbppyljcs9
hqckawk-gcc-12.3.0/include/c++/12.3.0/bits/chrono.h:386:14
#3 0x736d376b2b69 in std::cv_status std::condition_variable::wait_for<long, std::ratio<1l, 1000l>>(std::unique_lock<std::mut
ex>&, std::chrono::duration<long, std::ratio<1l, 1000l>> const&) /nix/store/fdiknsmnnczx6brsbppyljcs9hqckawk-gcc-12.3.0/include/
c++/12.3.0/condition_variable:164:6
#4 0x736d376b1ee9 in std::cv_status nix::Sync<nix::ProgressBar::State, std::mutex>::Lock::wait_for<long, std::ratio<1l, 1000
l>>(std::condition_variable&, std::chrono::duration<long, std::ratio<1l, 1000l>> const&) /home/jade/lix/lix/src/libutil/sync.hh:
65:23
#5 0x736d376b1ee9 in nix::ProgressBar::ProgressBar(bool)::'lambda'()::operator()() const /home/jade/lix/lix/src/libmain/prog
ress-bar.cc:99:27
#6 0x736d36de25c2 in execute_native_thread_routine (/nix/store/a3zlvnswi1p8cg7i9w4lpnvaankc7dxx-gcc-12.3.0-lib/lib/libstdc++
.so.6+0xe05c2)
#7 0x736d36b6b0e3 in start_thread (/nix/store/1zy01hjzwvvia6h9dq5xar88v77fgh9x-glibc-2.38-44/lib/libc.so.6+0x8b0e3) (BuildId
: 287831bffdbdde0ec25dbd021d12bdfc0ab9f5ff)
#8 0x736d36bed5e3 in __clone (/nix/store/1zy01hjzwvvia6h9dq5xar88v77fgh9x-glibc-2.38-44/lib/libc.so.6+0x10d5e3) (BuildId: 28
7831bffdbdde0ec25dbd021d12bdfc0ab9f5ff)
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /nix/store/fdiknsmnnczx6brsbppyljcs9hqckawk-gcc-12.3.0/include/c++/12.3.
0/bits/chrono.h:225:38 in
Change-Id: Ia0303242cdfd5d49385ae9e99718d709625a4633
lf-
added a commit
that referenced
this pull request
May 31, 2024
This is because a dynamic_cast<nix::RootArgs *> of a (n-e-j) MyArgs
returns nullptr even though MyArgs has virtual nix::RootArgs as a
parent.
class MyArgs : virtual public nix::MixEvalArgs,
virtual public nix::MixCommonArgs,
virtual nix::RootArgs { ... };
So this should work right?? But it does not. We found out that it's
caused by -fvisibility=hidden in n-e-j, but honestly this code was bad
anyway.
The trivial solution is to simply stop relying on RTTI working properly
here, which is probably better OO architecture anyway. However, I am not
100% confident *this* is sound, since we have this horrible hierarchy:
Args (defines getRoot)
/ | \
RootArgs MixCommonArgs MixEvalArgs
(overrides)
I am not confident that this is guaranteed to resolve from Args always
in the case of this override.
Assertion failed: (res), function getRoot, file src/libutil/args.cc, line 67.
6MyArgsProcess 60503 stopped
* thread #1, queue = 'com.apple.main-thread', stop reason = hit program assert
frame #4: 0x0000000100b1a41c liblixutil.dylib`nix::Args::processArgs(std::__1::list<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>> const&, bool) [inlined] nix::Args::getRoot(this=0x00000001000d0688) at args.cc:67:5 [opt]
64 std::cout << typeid(*p).name();
65
66 auto * res = dynamic_cast<RootArgs *>(p);
-> 67 assert(res);
68 return *res;
69 }
70
Target 0: (nix-eval-jobs) stopped.
(lldb) p this
(MyArgs *) 0x00000001000d0688
(lldb) p *this
(nix::Args) {
longFlags = size=180 { ... }
shortFlags = size=4 { ... }
expectedArgs = size=1 { ... }
processedArgs = size=0 {}
hiddenCategories = size=1 {
[0] = "Options to override configuration settings"
}
parent = nullptr
}
We also found that if we did this:
class [[gnu::visibility("default")]] RootArgs : virtual public Args
it would work properly (???!). This is of course, very strange, because
objdump -Ct output on liblixexpr.dylib is identical both with and
without it.
Possibly related: https://www.qt.io/blog/quality-assurance/one-way-dynamic_cast-across-library-boundaries-can-fail-and-how-to-fix-it
Fixes: https://git.lix.systems/lix-project/nix-eval-jobs/issues/2
Change-Id: I6b9ed968ed56420a9c4d2dffd18999d78c2761bd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps zeebe-io/backport-action from 1.4.0 to 2.4.1.
Release notes
Sourced from zeebe-io/backport-action's releases.
... (truncated)
Commits
e8161d6dist: release 2.4.12740887dist: build new versionec07f3eMerge pull request #410 from jschmid1/fix/template-rendering75b4a31fix: rendering templates due to missing brackets4e7a901dist: release 2.5.0-SNAPSHOT79b9f24dist: release 2.4.08546a41Merge pull request #409 from jschmid1/feat/pull_description_body29fedd9docs: reorder the placeholders alphanumerically258a18bdocs: align pull_description placeholder textba84c7afeat: addpull_descriptionto placeholdersDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)