Fix warnings with GCC 9 #480
Conversation
fs2tar.c: In function ‘parse_opt’: fs2tar.c:71:26: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Andreas Gnau <rondom@rondom.de>
lib/virtio_net_tap.c: In function ‘lkl_netdev_tap_create’: lib/virtio_net_tap.c:107:2: warning: ‘strncpy’ specified bound 16 equals destination size [-Wstringop-truncation] Signed-off-by: Andreas Gnau <rondom@rondom.de>
Rondom
force-pushed
the
compile-warnings
branch
from
c278050
to
b244a74
Compare
|
thanks, do you see why CI failed during code checkout ? |
Sorry, I somehow missed your message. I don't know the exact reason, but I have some guess. I use CircleCi myself and added it to my fork. I guess, my fork is lacking the Github credentials for cloning. (Why are you using SSH instead of anonymous HTTPS?) For some reason, no build got triggered in the LKL CircleCI account when I opened the PR. Maybe you can somehow trigger it manually? If not, I will delete LKL from my CircleCi account and then force-push a trivial change to trigger it again. |
lib/posix-host.c:189:49: warning: cast between incompatible function
types from ‘void (*)(void *)’ to ‘void * (*)(void *)’
[-Wcast-function-type]
lib/posix-host.c:270:28: warning: cast between incompatible function
types from ‘void (*)(void *)’ to ‘void (*)(union sigval)’
[-Wcast-function-type]
Signed-off-by: Andreas Gnau <rondom@rondom.de>
Rondom
force-pushed
the
compile-warnings
branch
from
b244a74
to
3c72f4a
Compare
|
Indeed that was the reason. I unfollowed my fork in CircleCi and then did a dummy-amend of my commit so that it would get rebuilt under LKL's CircleCI organisation. Seems like they consider this a known issue (or feature?) with exactly this workaround: https://support.circleci.com/hc/en-us/articles/360008097173-Why-aren-t-pull-requests-triggering-jobs-on-my-organization- |
This change is