Validate checkpoints in checkpoint_change() #2111
Open
+3
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this solves #2089
EDITED comment below in bold text
Upon reviewing the relevant code in this issue, I can see that the option
hr_checkpoint_name
was not **100% flawlessly ** validating the checkpoint before applyingcheckpoint_change()
. in processing module line 1272 I believe thatget_closet_checkpoint_match()
may possibly return an invalid value?First pass
sd_checkpoint_model
checkpoints were being validated outsidecheckpoint_change()
.Rather than creating another duplicate validation step specifically for
hr_checkpoint_name
outside the function, simply validate all checkpoints withincheckpoint_change()