Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate checkpoints in checkpoint_change() #2111

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

altoiddealer
Copy link
Contributor

@altoiddealer altoiddealer commented Oct 18, 2024

I believe this solves #2089

EDITED comment below in bold text

Upon reviewing the relevant code in this issue, I can see that the option hr_checkpoint_name was not **100% flawlessly ** validating the checkpoint before applying checkpoint_change(). in processing module line 1272 I believe that get_closet_checkpoint_match() may possibly return an invalid value?

First pass sd_checkpoint_model checkpoints were being validated outside checkpoint_change().

Rather than creating another duplicate validation step specifically for hr_checkpoint_name outside the function, simply validate all checkpoints within checkpoint_change()

first pass checkpoints were being validated outside the function, but not HR fix checkpoints.  Rather than creating redundant validation steps outside the function, this is now validated within the function for all checkpoints being set/loaded.
@altoiddealer
Copy link
Contributor Author

A part of me wants to mark this as "Draft", because I'm starting to think this does not solve #2089

I'm leaving this open as I think it is still a good idea to validate all requested checkpoint changes in this function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant