refactor: restructure the implementation #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smusali
force-pushed
the
smusali/LOG-7522
branch
from
d9d99cb
to
6d9099d
Compare
smusali
requested review from
dm36,
jakedipity and
matt-march
and removed request for
a team
smusali
force-pushed
the
smusali/LOG-7522
branch
from
6d9099d
to
6a13c57
Compare
matt-march
reviewed
Oct 19, 2020
smusali
force-pushed
the
smusali/LOG-7522
branch
from
6f80da5
to
2184c4b
Compare
evanlucas
suggested changes
Oct 20, 2020
smusali
force-pushed
the
smusali/LOG-7522
branch
from
2184c4b
to
cfbd04f
Compare
|
Thanks for the feedback, guys @evanlucas @matt-march! I have decided to make changes one-by-one as listed here |
smusali
requested review from
mdeltito
and removed request for
dm36 and
jakedipity
smusali
force-pushed
the
smusali/LOG-7522
branch
from
cfbd04f
to
86f4799
Compare
smusali
changed the title
smusali
changed the title
smusali
force-pushed
the
smusali/LOG-7522
branch
4 times, most recently
from
c1455c3
to
29cd013
Compare
smusali
force-pushed
the
smusali/LOG-7522
branch
3 times, most recently
from
e5ababb
to
55f81d0
Compare
smusali
force-pushed
the
smusali/LOG-7522
branch
from
55f81d0
to
1448432
Compare
mdeltito
reviewed
Apr 28, 2021
smusali
force-pushed
the
smusali/LOG-7522
branch
from
1448432
to
7771f83
Compare
smusali
force-pushed
the
smusali/LOG-7522
branch
from
7771f83
to
999096a
Compare
tanberry
previously approved these changes
Apr 28, 2021
alfeng6
reviewed
Apr 28, 2021
alfeng6
reviewed
Apr 28, 2021
alfeng6
reviewed
Apr 28, 2021
alfeng6
reviewed
Apr 28, 2021
alfeng6
suggested changes
Apr 28, 2021
Include the same `CONTRIBUTING.md` and `CODE_OF_CONDUCT.md` we have been using for other repos. Ref: #8 Semver: patch
smusali
force-pushed
the
smusali/LOG-7522
branch
from
999096a
to
3dd200c
Compare
|
Resolved all; I think, it's good to go, right, @mdeltito @alfeng6 @tanberry @darinspivey? |
tanberry
approved these changes
Apr 28, 2021
mdeltito
approved these changes
Apr 29, 2021
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: restructure the implementation
This commit is also introducing huge data handling, which is needed mainly for CloudTrail.
Ref: #2
Semver: major
test: add unit test coverage
Initializing TAP and adding unit test cases to cover all the cases
Ref: #3
Semver: patch
feat(config): use @logdna/env-config for configuration
Replace current configuration with @logdna/env-logdna
Ref: #2
Semver: major
refactor(logger): introduce @logdna/logger as a logger
Replacing the current flushing mechanism with @logdna/logger
Ref: #2
Semver: minor
docs: update README and Contribution Guide and add Code of Conduct
Include the same
CONTRIBUTING.mdandCODE_OF_CONDUCT.mdwe have been using for other repos.Ref: #8
Semver: patch