add advanced invoice #8

SashaDi13 · 2024-08-12T14:32:20Z

No description provided.

mdotvasylenchuk · 2024-08-13T08:45:29Z

lib/monopay-ruby/invoices/simple_invoice.rb

@@ -35,6 +36,7 @@ def create(amount, destination: nil, reference: nil)
          @amount = convert_to_cents(amount)
          @destination = destination
          @reference = reference
+          binding.pry


забула

mdotvasylenchuk · 2024-08-13T08:45:35Z

lib/monopay-ruby/invoices/simple_invoice.rb

@@ -1,5 +1,6 @@
 require "bigdecimal"
 require "money"
+require "pry"


не треба тут

mdotvasylenchuk · 2024-08-13T08:46:52Z

lib/monopay-ruby/invoices/advanced_invoice.rb

+require_relative 'simple_invoice'
+module MonopayRuby


Suggested change

require_relative 'simple_invoice'

module MonopayRuby

require_relative 'simple_invoice'

module MonopayRuby

mdotvasylenchuk · 2024-08-13T09:00:54Z

CHANGELOG.md

@@ -1,3 +1,7 @@
+## [1.1.0] - 2024-08-12
+- add `MonopayRuby::Invoices::AdvancedInvoice`


а чому AdvancedInvoice? В чім його різниця порівняно з simple invoice? І потрібно описати детально функціонал який додається

mdotvasylenchuk · 2024-08-13T09:01:41Z

CHANGELOG.md

@@ -1,3 +1,7 @@
+## [1.1.0] - 2024-08-12
+- add `MonopayRuby::Invoices::AdvancedInvoice`
+- change private method `request_body` to private


тобто прайват змінився на прайват? Виглядає по опису що нічого не змінилося, опиши детально що відбулося тут

mdotvasylenchuk · 2024-08-13T09:02:19Z

CHANGELOG.md

+## [1.1.0] - 2024-08-12
+- add `MonopayRuby::Invoices::AdvancedInvoice`
+- change private method `request_body` to private
+- modify `README.md`


яка саме модифікація відбулася?

mdotvasylenchuk · 2024-08-13T09:02:46Z

README.md

+      "https://example.com",
+      "https://example.com/payments/webhook"


що це за лінки? Де дока для них?

цей код взагалі не працює

буде помилка параметрів, бо мають бути неймед параметри

mdotvasylenchuk · 2024-08-13T09:08:06Z

lib/monopay-ruby/invoices/advanced_invoice.rb

+        @basketOrder = basketOrder
+        @otherParams = otherParams


чому тут використаний кемл кейс?

loqimean · 2024-08-13T11:50:18Z

README.md

+      "https://example.com",
+      "https://example.com/payments/webhook"


цей код взагалі не працює

loqimean · 2024-08-13T11:50:43Z

README.md

+      "https://example.com",
+      "https://example.com/payments/webhook"


буде помилка параметрів, бо мають бути неймед параметри

loqimean · 2024-08-13T11:54:38Z

lib/monopay-ruby/invoices/advanced_invoice.rb

+        # TODO: add "ccy" and another missing params
+        # TODO: remove nil valued params


resolve this todos, or remove

loqimean · 2024-08-13T11:57:08Z

lib/monopay-ruby/invoices/advanced_invoice.rb

+          }
+        }
+
+        request_body[:merchantPaymInfo][:basketOrder] = basketOrder if basketOrder.any?


а якщо request_body[:merchantPaymInfo] буде ніл?

loqimean · 2024-08-13T11:57:18Z

lib/monopay-ruby/invoices/advanced_invoice.rb

+        }
+
+        request_body[:merchantPaymInfo][:basketOrder] = basketOrder if basketOrder.any?
+        request_body.merge!(otherParams).to_json


навіщо тобі бенг метод тут?

loqimean · 2024-08-21T15:21:19Z

lib/monopay-ruby/invoices/advanced_invoice.rb

+        request_body[:merchantPaymInfo] = request_body[:merchantPaymInfo].merge!(other_merchant_paymant_info_params) # add additional merchant_payment_info params if they are present
+        request_body.merge!(other_params)                             # add additional params if they are present


remove redundant comments, because they describe the code point in point

loqimean · 2024-08-21T15:21:51Z

lib/monopay-ruby/invoices/advanced_invoice.rb

+        if request_body[:merchantPaymInfo].has_key?(:basketOrder)
+          request_body[:merchantPaymInfo][:basketOrder].first[:sum] = convert_to_cents(amount)


this is unsafe, cehck if first param present to prevent NilClass undefined method error

loqimean · 2024-08-21T15:23:34Z

lib/monopay-ruby/invoices/advanced_invoice.rb

+        if request_body[:merchantPaymInfo].has_key?(:basketOrder)
+          request_body[:merchantPaymInfo][:basketOrder].first[:sum] = convert_to_cents(amount)
+        elsif request_body.has_key?(:items)
+          request_body[:items].first[:sum] = convert_to_cents(amount)


this is also unsafe, so, you check for the key presence, but value might be nil

loqimean · 2024-08-21T15:24:39Z

lib/monopay-ruby/invoices/advanced_invoice.rb

+  private
+
+  def sum_param_into_basket
+    request_body[:merchantPaymInfo][:basketOrder][:qty] * amount


add some return if any of parameter is blank

loqimean · 2024-08-21T15:26:38Z

lib/monopay-ruby/invoices/advanced_invoice.rb

+  def sum_param_into_basket
+    request_body[:merchantPaymInfo][:basketOrder][:qty] * amount


this method isn't used anywhere

loqimean · 2024-08-28T16:51:58Z

Gemfile

@@ -6,3 +6,5 @@ source "https://rubygems.org"
 gemspec

 gem "rake", "~> 13.0"
+gem 'activesupport', '~> 7.0'


це точно потрібно?

loqimean · 2024-08-28T16:52:04Z

Gemfile

@@ -6,3 +6,5 @@ source "https://rubygems.org"
 gemspec

 gem "rake", "~> 13.0"
+gem 'activesupport', '~> 7.0'
+gem 'yard'


а це взагалі видаляй

loqimean · 2024-08-28T16:52:30Z

CHANGELOG.md

+- change private methods to protected
+- modify `request_body` for additional params
+- add protected method `default_params`
+- add more details about `MonopayRuby::Invoices::AdvancedInvoice` into `README.md`


це не потрібно

loqimean · 2024-08-28T16:53:04Z

CHANGELOG.md

+- change private methods to protected
+- modify `request_body` for additional params
+- add protected method `default_params`


це вже прям деталі реалізації, вони не важливі для користувача

loqimean · 2024-08-28T16:53:27Z

lib/monopay-ruby/invoices/advanced_invoice.rb

+      #
+      # @example Create a payment with amount and additional parameters
+      #   create(100, additional_params: { merchantPaymInfo: { destination: "Happy payment", reference: "ref123" } })
+


Suggested change

loqimean · 2024-08-28T16:54:17Z

lib/monopay-ruby/invoices/simple_invoice.rb

@@ -1,3 +1,4 @@
+require 'active_support/all'


так а це навіщо?)

це, як і гем мені потрібний для методу blank?

ну диви, в сімпл інвойсі воно не потрібне точно, бо не юзається, а так, то хз, я б сказав, що оке, най буде поки що

loqimean · 2024-08-28T16:55:08Z

spec/lib/invoices/advanced_invoice_spec.rb

+      end
+
+      it "returns true" do
+        expect(simple_invoice_instance.create(2000, other_merchant_paymant_info_params: {basketOrder: [basket_order]}, other_params: other_params)).to be_truthy


винеси параметри в let

loqimean · 2024-08-28T16:56:05Z

lib/monopay-ruby/invoices/advanced_invoice.rb

+        @destination = @additional_params&.dig(:merchantPaymInfo, :destination)
+        @reference = @additional_params&.dig(:merchantPaymInfo, :reference)


так це ріквайред параметри, вони не можуть бути відсутні, якщо ж відсутні, то рейзани якусь помилку

але ж вони по дефолту ніл, то чому ж вони ріквайред?

loqimean · 2024-08-28T16:56:35Z

lib/monopay-ruby/invoices/advanced_invoice.rb

+
+        current_params.merge!(additional_params.except(:merchantPaymInfo))
+
+        # TODO: add sum and qty params into present additional params


а щодо цього комента що?

loqimean · 2024-08-28T16:57:21Z

lib/monopay-ruby/invoices/advanced_invoice.rb

+        set_sum_and_qty_params(current_params&.dig(:merchantPaymInfo, :basketOrder))
+        set_sum_and_qty_params(current_params[:items])


поясни будь ласка, що тут відбувається

я спробувала розписати це у коментарях

loqimean · 2024-10-11T14:08:49Z

lib/monopay-ruby/invoices/simple_invoice.rb

@@ -1,3 +1,4 @@
+require 'active_support/all'


ну диви, в сімпл інвойсі воно не потрібне точно, бо не юзається, а так, то хз, я б сказав, що оке, най буде поки що

loqimean · 2024-10-11T14:09:20Z

lib/monopay-ruby/invoices/advanced_invoice.rb

+        # TODO: add and modify sum and qty params of merchantPaymInfo[basketOrder] parameters if it is present
+        # TODO: add and modify sum and qty params of items parameters if it is present


для чого ці ту-ду?)

або пофіксай, або прибери)

SashaDi13 force-pushed the advanced-invoice branch 3 times, most recently from 882cf4f to d7cfca0 Compare August 13, 2024 08:39

mdotvasylenchuk reviewed Aug 13, 2024

View reviewed changes

SashaDi13 force-pushed the advanced-invoice branch 2 times, most recently from 827aeab to ae19af2 Compare August 13, 2024 08:48

mdotvasylenchuk reviewed Aug 13, 2024

View reviewed changes

SashaDi13 force-pushed the advanced-invoice branch 2 times, most recently from c4494c9 to e04bf70 Compare August 13, 2024 13:45

mdotvasylenchuk approved these changes Aug 13, 2024

View reviewed changes

SashaDi13 force-pushed the advanced-invoice branch from e04bf70 to 9018f07 Compare August 15, 2024 10:28

loqimean requested changes Aug 21, 2024

View reviewed changes

SashaDi13 force-pushed the advanced-invoice branch 4 times, most recently from 222b580 to bd97df8 Compare August 27, 2024 09:07

loqimean requested changes Aug 28, 2024

View reviewed changes

SashaDi13 force-pushed the advanced-invoice branch from bd97df8 to b2acd0c Compare August 28, 2024 19:43

add advanced invoive

d86027e

SashaDi13 force-pushed the advanced-invoice branch from b2acd0c to d86027e Compare August 28, 2024 19:53

loqimean requested changes Oct 11, 2024

View reviewed changes

		@@ -1,3 +1,7 @@
		## [1.1.0] - 2024-08-12
		- add `MonopayRuby::Invoices::AdvancedInvoice`

		"https://example.com",
		"https://example.com/payments/webhook"

		# TODO: add "ccy" and another missing params
		# TODO: remove nil valued params

		request_body[:merchantPaymInfo] = request_body[:merchantPaymInfo].merge!(other_merchant_paymant_info_params) # add additional merchant_payment_info params if they are present
		request_body.merge!(other_params) # add additional params if they are present

		if request_body[:merchantPaymInfo].has_key?(:basketOrder)
		request_body[:merchantPaymInfo][:basketOrder].first[:sum] = convert_to_cents(amount)

		def sum_param_into_basket
		request_body[:merchantPaymInfo][:basketOrder][:qty] * amount

		@destination = @additional_params&.dig(:merchantPaymInfo, :destination)
		@reference = @additional_params&.dig(:merchantPaymInfo, :reference)


		current_params.merge!(additional_params.except(:merchantPaymInfo))

		# TODO: add sum and qty params into present additional params

		set_sum_and_qty_params(current_params&.dig(:merchantPaymInfo, :basketOrder))
		set_sum_and_qty_params(current_params[:items])

		# TODO: add and modify sum and qty params of merchantPaymInfo[basketOrder] parameters if it is present
		# TODO: add and modify sum and qty params of items parameters if it is present

add advanced invoice #8

Are you sure you want to change the base?

add advanced invoice #8

Conversation

SashaDi13 commented Aug 12, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment