Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Ciphers option to SSL Option #3

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

saiqulhaq
Copy link
Contributor

Faraday 2.11.0 has new SSL option: ciphers

@saiqulhaq
Copy link
Contributor Author

image

@saiqulhaq
Copy link
Contributor Author

This PR is to fix one of these tasks

@olleolleolle
Copy link
Member

A detail with this is: the gem will no longer after this change support Faraday 1.

Perhaps we can make it support both versions? A conditional checking for the Faraday version before trying to set the ciphers setting? Something, so that we don't have to maintain a branch with a Faraday 1.x version.

@saiqulhaq
Copy link
Contributor Author

OK let me try to make it work with Faraday v1 and v2

@saiqulhaq
Copy link
Contributor Author

RSpec with Ruby v3.3
image

RSpec with Ruby v2.6, Faraday 2.8
image

RSpec with Ruby v2.6, Faraday 1.10

  spec.add_dependency 'faraday', '~> 1.10.3'

root@41de205654e6:/app# bundle show faraday
/bundle/gems/faraday-1.10.3

image

there is an issue with Faraday v1
I had to add gem 'multipart-parser', '~> 0.1.1' to Gemfile manually

I want to add Appraisal, but it's hard since too many combinations of the Ruby and Faraday versions need to be supported.
Even the Rubocop spec is failing in the CI.

FYI, I created a new gem to switch between Ruby versions easily without bloating up our machine -> https://github.com/saiqulhaq/gemdock
https://saiqulhaq.id/very-fast-ruby-gem-development-testing

@olleolleolle
Copy link
Member

Ha, I failed to fix the Gemfile right, I _removed_a newline, which is now a lint failure. Sorry!

Gemfile:16:37: C: [Correctable] Layout/TrailingEmptyLines: Final newline missing. (https://rubystyle.guide#newline-eof)
gem 'rubocop-performance', '~> 1.20'

@saiqulhaq
Copy link
Contributor Author

All checks have passed now @olleolleolle

@olleolleolle
Copy link
Member

@saiqulhaq Can you make a rebase on top of latest changes, and force-push this branch? "This branch cannot be rebased due to conflicts" it says in the GitHub web interface, now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants