-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Ciphers option to SSL Option #3
base: main
Are you sure you want to change the base?
Conversation
1c1a7d7
to
1dccb9e
Compare
This PR is to fix one of these tasks |
A detail with this is: the gem will no longer after this change support Faraday 1. Perhaps we can make it support both versions? A conditional checking for the Faraday version before trying to set the ciphers setting? Something, so that we don't have to maintain a branch with a Faraday 1.x version. |
OK let me try to make it work with Faraday v1 and v2 |
RSpec with Ruby v2.6, Faraday 2.8 RSpec with Ruby v2.6, Faraday 1.10
there is an issue with Faraday v1 I want to add Appraisal, but it's hard since too many combinations of the Ruby and Faraday versions need to be supported. FYI, I created a new gem to switch between Ruby versions easily without bloating up our machine -> https://github.com/saiqulhaq/gemdock |
c9fd6b9
to
8a5b8a7
Compare
Ha, I failed to fix the Gemfile right, I _removed_a newline, which is now a lint failure. Sorry!
|
All checks have passed now @olleolleolle |
@saiqulhaq Can you make a rebase on top of latest changes, and force-push this branch? "This branch cannot be rebased due to conflicts" it says in the GitHub web interface, now. |
86633e9
to
f40eb65
Compare
Faraday 2.11.0 has new SSL option:
ciphers