Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Support ciphers SSLOptions #24

Merged
merged 9 commits into from
Oct 7, 2024

Conversation

saiqulhaq
Copy link
Contributor

To resolve one of these tasks

@saiqulhaq
Copy link
Contributor Author

saiqulhaq commented Sep 9, 2024

image
tests are successful

@saiqulhaq
Copy link
Contributor Author

image

Finished in 0.45295 seconds (files took 0.179 seconds to load)
353 examples, 0 failures

Faraday 2.8 Ruby 2.7

Finished in 0.40026 seconds (files took 0.16809 seconds to load)
353 examples, 0 failures

Copy link
Member

@iMacTia iMacTia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of minor comments on the versioning, but I can do those changes quite quickly myself.
Apologies if it took this long to review this, and thank you for going through the various adapters to add support for ciphers 🙇

Gemfile Outdated Show resolved Hide resolved
faraday-net_http_persistent.gemspec Outdated Show resolved Hide resolved
@iMacTia iMacTia assigned iMacTia and unassigned iMacTia Oct 7, 2024
@iMacTia
Copy link
Member

iMacTia commented Oct 7, 2024

Managed to do those small changes myself with the web editor (pretty cool!).
All tests seem to be passing now, thank you @saiqulhaq !

@iMacTia iMacTia merged commit 4908b44 into lostisland:main Oct 7, 2024
7 checks passed
@saiqulhaq saiqulhaq deleted the feat/support-ciphers branch October 8, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants