Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve README.md about exceptions config #35

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Improve README.md about exceptions config #35

merged 2 commits into from
Feb 20, 2024

Conversation

mi-wada
Copy link
Contributor

@mi-wada mi-wada commented Feb 19, 2024 •
edited
Loading

Thank you for all your wonderful gem.

Why

Because there were some points that could be improved regarding the explanation of the exceptions config.

What

@mi-wada mi-wada changed the title Improve README.md Improve README.md about exceptions setting Feb 19, 2024
@mi-wada mi-wada changed the title Improve README.md about exceptions setting Improve README.md about exceptions config Feb 20, 2024
iMacTia
iMacTia approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@iMacTia iMacTia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition, thank you @mi-wada 🙇

@iMacTia iMacTia added this pull request to the merge queue Feb 20, 2024
Merged via the queue into lostisland:main with commit f1929d9 Feb 20, 2024
@mi-wada mi-wada deleted the improve-readme branch February 20, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iMacTia iMacTia iMacTia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mi-wada @iMacTia