Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove momentJS #333

Merged
merged 6 commits into from
Aug 23, 2023
Merged

Conversation

raheeliftikhar5
Copy link
Collaborator

Proposed changes

Remove momentJS dependency and use dayJS which is recommended by antd v5.

Types of changes

What types of changes does your code introduce to Lowcoder?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

@netlify
Copy link

netlify bot commented Aug 2, 2023

Deploy Preview for lowcoder-cloud ready!

Name Link
🔨 Latest commit 92b5788
🔍 Latest deploy log https://app.netlify.com/sites/lowcoder-cloud/deploys/64e665f33cf76700082b7eb0
😎 Deploy Preview https://deploy-preview-333--lowcoder-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@raheeliftikhar5 raheeliftikhar5 changed the title Remove moment Remove momentJS Aug 2, 2023
FalkWolsky
FalkWolsky previously approved these changes Aug 7, 2023
Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this contribution! That looks really good.

@FalkWolsky FalkWolsky merged commit d9debc7 into lowcoder-org:main Aug 23, 2023
3 checks passed
@raheeliftikhar5 raheeliftikhar5 deleted the remove-moment branch November 29, 2023 10:49
@raheeliftikhar5 raheeliftikhar5 restored the remove-moment branch November 29, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants