Windows support #1069
Merged
Windows support #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d the highest Postgres versions
…ed precompiled task to bin and set as a target
jwoertink
commented
Oct 12, 2024
| shard_file: | ||
| - shard.yml | ||
| postgres_version: | ||
| - 14 | ||
| - 15 |
There was a problem hiding this comment.
No need to check every single version. I think just checking the lowest and the highest versions is fine and assume everything in the middle "just works".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1067
This is an attempt at adding native Windows support. It was all written on Linux... wish me luck(y) 😂
At the moment it seems that we will need to require at least Crystal 1.14 or later for the Windows to work. I've opened an issue on PG will/crystal-pg#291 related to the failure. This may be as close as we can get for now.