-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Create initial pinata implementation. Pinata has different apis node/browser due to FormData #222
base: develop
Are you sure you want to change the base?
Conversation
b4919b6
to
311d4b4
Compare
…s and url converters
9996136
to
9668b50
Compare
Converting this to draft. Due to signer/nonce the test scripts are flaky. |
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## develop #222 +/- ##
============================================
+ Coverage 19.60% 84.47% +64.86%
============================================
Files 15 19 +4
Lines 1066 1172 +106
Branches 373 356 -17
============================================
+ Hits 209 990 +781
+ Misses 834 160 -674
+ Partials 23 22 -1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@CallumGrindle I had to disable the JWT test, because it now depends on GCP KMS being available in github actions. |
We're going to push a bunch of the IPFS stuff into erc725 and leave the jest and so fixes here. |
What kind of change does this PR introduce (bug fix, feature, docs update, ...)?
Initial implementation of more generic uploader and URL converter
Implement first ifps-http-client
Implement second pinata
Show example implementation of new upload provider