chore(core): remove moment and deprecated date-picker utils

lumapps · Sep 28, 2023 · 3ee14b7 · 3ee14b7
1 parent b8cc29a
commit 3ee14b7
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 102 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Removed
+
+-   _[BREAKING]_ `@lumx/core/js/utils/date-picker` date util functions have been removed, replaced with internal utils (not using moment anymore)
+
 ### Changed
 
 -   `@lumx/react` no long depend on `moment` or `moment-range` to generate the date picker.

diff --git a/packages/lumx-core/package.json b/packages/lumx-core/package.json
@@ -73,9 +73,5 @@
         "webpack": "^4.44.1",
         "webpack-notifier": "^1.8.0",
         "webpackbar": "^4.0.0"
-    },
-    "peerDependencies": {
-        "moment": ">= 2",
-        "moment-range": "^4.0.2"
     }
 }
diff --git a/packages/lumx-core/src/js/date-picker.ts b/packages/lumx-core/src/js/date-picker.ts
diff --git a/packages/lumx-core/webpack.config.js b/packages/lumx-core/webpack.config.js
@@ -143,7 +143,7 @@ module.exports = {
         ),
     },
 
-    externals: ['moment', 'moment-range'],
+    externals: [],
 
     bail: true,
     devtool: 'source-map',

diff --git a/packages/site-demo/package.json b/packages/site-demo/package.json
@@ -44,8 +44,6 @@
         "intersection-observer": "^0.7.0",
         "lodash": "4.17.21",
         "lunr": "^2.3.9",
-        "moment": "^2.29.4",
-        "moment-range": "^4.0.2",
         "prism-react-renderer": "^0.1.5",
         "prismjs": "^1.25.0",
         "react": "^17.0.2",

diff --git a/yarn.lock b/yarn.lock
@@ -6100,9 +6100,6 @@ __metadata:
     webpack: ^4.44.1
     webpack-notifier: ^1.8.0
     webpackbar: ^4.0.0
-  peerDependencies:
-    moment: ">= 2"
-    moment-range: ^4.0.2
   languageName: unknown
   linkType: soft
 
@@ -15357,7 +15354,7 @@ __metadata:
   languageName: node
   linkType: hard
 
-"es6-symbol@npm:^3.1.0, es6-symbol@npm:^3.1.1, es6-symbol@npm:~3.1.2":
+"es6-symbol@npm:^3.1.1, es6-symbol@npm:~3.1.2":
   version: 3.1.3
   resolution: "es6-symbol@npm:3.1.3"
   dependencies:
@@ -23889,8 +23886,6 @@ fsevents@~2.1.2:
     intersection-observer: ^0.7.0
     lodash: 4.17.21
     lunr: ^2.3.9
-    moment: ^2.29.4
-    moment-range: ^4.0.2
     prism-react-renderer: ^0.1.5
     prismjs: ^1.25.0
     react: ^17.0.2
@@ -25016,18 +25011,7 @@ fsevents@~2.1.2:
   languageName: node
   linkType: hard
 
-"moment-range@npm:^4.0.2":
-  version: 4.0.2
-  resolution: "moment-range@npm:4.0.2"
-  dependencies:
-    es6-symbol: ^3.1.0
-  peerDependencies:
-    moment: ">= 2"
-  checksum: ff7425eed2600b1450ae25a7d074fb1edbc7956199f9eca974d5b2bc7885912dd08205e55675eb1b8cbbdcb3647622748861822580bd7327e680ca2202f8ee31
-  languageName: node
-  linkType: hard
-
-"moment@npm:^2.27.0, moment@npm:^2.29.4":
+"moment@npm:^2.27.0":
   version: 2.29.4
   resolution: "moment@npm:2.29.4"
   checksum: 0ec3f9c2bcba38dc2451b1daed5daded747f17610b92427bebe1d08d48d8b7bdd8d9197500b072d14e326dd0ccf3e326b9e3d07c5895d3d49e39b6803b76e80e