Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(subheader): change color to dark-L2 #1018

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

Richard-lumapps
Copy link
Contributor

@Richard-lumapps Richard-lumapps commented Oct 4, 2023

CF-486

General summary

In order to fix insufficient contrast ratio with SubHeader component, changed color from dark-L3 to dark-L2.

Screenshots

using dark L3:
darkl3

using dark L2:
darkl2

StoryBook: https://b59d5881--5fbfb1d508c0520021560f10.chromatic.com/ (Chromatic build) ⚠️ Outdated commit

@FlorentDinet
Copy link
Contributor

All good for me

Copy link
Member

@gcornut gcornut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you modify the CHANGELOG.md in ## [Unreleased] > ### Changed?
I would suggest something like:

     - ListSubHeader: darken text color for better accessibility

@Richard-lumapps
Copy link
Contributor Author

Can you modify the CHANGELOG.md in ## [Unreleased] > ### Changed? I would suggest something like:

     - ListSubHeader: darken text color for better accessibility

My bad, forgot to do this. This is done now.

@gcornut gcornut merged commit 671fcca into master Oct 4, 2023
6 checks passed
@gcornut gcornut deleted the fix/CF-486_update_subheader_color branch October 4, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants