Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(workflow): rework release and prerelease workflows #1173

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

gcornut
Copy link
Member

@gcornut gcornut commented Aug 30, 2024

General summary

Split release and prerelease workflows

  • "Prerelease workflow" is manully triggered and pushes to NPM without PR or tag
  • "Prepare release workflow" is manually triggered and only opens a PR with version incremented
  • "Publish Release Workflow" is triggered when merging the release commit on master and triggers publish on NPM, chromatic, docker, etc.

Test

It's difficult to test these because we can't trigger manual workflow from a PR but we can stub some parts and run other parts on PR push

@gcornut gcornut force-pushed the chore_workflow_rework_the_release_workflow branch 19 times, most recently from 8d4808b to 0a6a01e Compare September 2, 2024 15:31
@gcornut gcornut force-pushed the chore_workflow_rework_the_release_workflow branch 3 times, most recently from 1233ca6 to 2209bde Compare September 2, 2024 16:01
@gcornut gcornut marked this pull request as ready for review September 2, 2024 16:10
@gcornut gcornut force-pushed the chore_workflow_rework_the_release_workflow branch from 2209bde to aabdcc4 Compare September 2, 2024 16:10
@gcornut gcornut requested review from lumautomation and a team as code owners September 2, 2024 16:10
Copy link
Contributor

@hchevallier hchevallier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gcornut
Copy link
Member Author

gcornut commented Sep 3, 2024

Test OK deploy demo site ✅

@gcornut gcornut force-pushed the chore_workflow_rework_the_release_workflow branch from 2194ef8 to a614b4c Compare September 3, 2024 07:57
@gcornut gcornut merged commit 758ea8a into master Sep 3, 2024
7 checks passed
@gcornut gcornut deleted the chore_workflow_rework_the_release_workflow branch September 3, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants