Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(image-lightbox): minor fixes #1181

Merged
merged 2 commits into from
Sep 13, 2024
Merged

fix(image-lightbox): minor fixes #1181

merged 2 commits into from
Sep 13, 2024

Conversation

gcornut
Copy link
Member

@gcornut gcornut commented Sep 6, 2024 •
edited by github-actions bot
Loading

  • fix(image-lightbox): update props each time the lightbox opens
  • fix(image-lightbox): fix reset zoom scale when switching to the first item

StoryBook: https://ede04ee6--5fbfb1d508c0520021560f10.chromatic.com/ (Chromatic build)

@gcornut gcornut marked this pull request as ready for review September 13, 2024 08:05
@gcornut gcornut requested review from lumautomation and a team as code owners September 13, 2024 08:05
@gcornut gcornut force-pushed the fix_image-lightbox_fix_reset_zoom_scale_when_switching_to_the_first_item branch from d10a1d8 to ede04ee Compare September 13, 2024 08:55
@gcornut
Copy link
Member Author

gcornut commented Sep 13, 2024

Test OK

  • Zoom is correctly reset when switching to the first slide ✅
  • "Update props" fix is not directly testable here but at least it doesn't produce any regression ✅

@gcornut gcornut merged commit 0c749c9 into master Sep 13, 2024
11 checks passed
@gcornut gcornut deleted the fix_image-lightbox_fix_reset_zoom_scale_when_switching_to_the_first_item branch September 13, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hchevallier hchevallier hchevallier approved these changes

@lumautomation lumautomation Awaiting requested review from lumautomation lumautomation is a code owner

Assignees
No one assigned
Labels
need: test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gcornut @hchevallier