fix(button-group): fixed border style with hidden or single child #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test OK Correct border radius with visually-hidden children in first and last position: ✅ |
gcornut
force-pushed
the
fix_button-group_fixed_border_style_with_hidden_or_single_child
branch
from
70b28dd
to
7fb5107
Compare
|
Fixed lint in stories, no need to re-test |
hchevallier
approved these changes
Sep 16, 2024
gcornut
deleted the
fix_button-group_fixed_border_style_with_hidden_or_single_child
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General summary
Make sure that the border radius of the first button is only applied on the left and the border radius of the last button is only applied on the right.
Ignore .visually-hidden children (the border radius was applied to them if they were placed in first or last position)
Make it work with a signle button (the left border radius was removed)
StoryBook: https://70b28dd0--5fbfb1d508c0520021560f10.chromatic.com/ (Chromatic build)⚠️ Outdated commit