feat(tooltip): use standard visually-hidden class in closeMode=hide #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hchevallier
approved these changes
Oct 9, 2024
|
Test OK |
gcornut
force-pushed
the
feat_tooltip_use_standard_visually-hidden_class_in_closemode_hide
branch
from
4b71eb3
to
f910b01
Compare
gcornut
deleted the
feat_tooltip_use_standard_visually-hidden_class_in_closemode_hide
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General summary
Use the standard visually-hidden class on Tooltip closeMode=hide instead of a custom class
Test scenarios
Tooltip closeMode=hide
StoryBook: https://4b71eb32--5fbfb1d508c0520021560f10.chromatic.com/ (Chromatic build)⚠️ Outdated commit