Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve names hierarchy #293

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AlexisBRENON
Copy link
Contributor

To follow PR #253, this improves handling of names hierarchy:

  • Generate names hierarchy in the right place in the code
  • Treat specifically topic and examples files

By the way, it updates the version number. If accepted, I will update documentation accordingly.

Copy link
Member

@alerque alerque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to contribute.

I'll be honest this kind of makes sense to me, but I don't really understand why you moved some of the cheese and I don't have a use case where I'm confident of seeing the different you were going for. Can you suggest a project where their LDoc generated files are up to date that I can compare and see what difference this makes so I can evaluate it better?

@@ -30,7 +30,7 @@ utils.unpack = utils.unpack or unpack or table.unpack
local append = table.insert
local lapp = require 'pl.lapp'

local version = '1.4.6'
local version = '1.4.7'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't bump the version number as part of PR's, well do that right before an actual release.

@AlexisBRENON
Copy link
Contributor Author

If I moved the cheese, it's probably because it didn't worked as I expected it before. I think that there is special cases where I need the this_mod.file.lang.method_call variable and hence, required to move the call to split.

If I remember well, I used it for the documentation of my thesis project: https://brenona.gricad-pages.univ-grenoble-alpes.fr/arcades/

I think I used it for the navigation bar: https://gricad-gitlab.univ-grenoble-alpes.fr/brenona/arcades/-/blob/master/assets/ldoc/ldoc.ltp#L33

It makes some times since I worked on this. If you want me to test some things, be precise please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants