Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inputSelect inputOrderBy and inputInclude #19

Closed
wants to merge 3 commits into from

Conversation

fortezhuo
Copy link

I just make simple patch, refactoring relations.ts, and bump dependencies.
Please review

@m1212e
Copy link
Owner

m1212e commented Sep 13, 2024

Hi, thank you very much for your input! I'll take time to review this throughout the next week or so. Do you have some deadline/is this urgent for you?

@fortezhuo
Copy link
Author

I think I still can run and build generated files on my local computers and copy them manually.

So no worries, I can wait. Please take your time to review 🙏

@m1212e
Copy link
Owner

m1212e commented Sep 17, 2024

Hey, I took a first look and I'd like to rework a few things to make it comply to the current project structure. I'll do this throughout the next days and merge as soon as it's ready! Thanks for your contribution!

@m1212e m1212e linked an issue Sep 17, 2024 that may be closed by this pull request
@fortezhuo
Copy link
Author

fortezhuo commented Sep 17, 2024

Thanks. but I found the whereSchema also need to be tweaked. If we need to use combination operator like contains, gt, lt, etc the current where schema still not supported. I still dev this feature, and tested it.. if it's ready, I will make another PR.
https://www.prisma.io/docs/orm/prisma-client/queries/filtering-and-sorting

@m1212e
Copy link
Owner

m1212e commented Sep 18, 2024

I've implemented simplified models to validate the other query options you requested in the latest release. I took some inspiration from you PR but ultimately decided to implemet it on the main. Feel free to take a look and close/fork if you want to!

@fortezhuo
Copy link
Author

fortezhuo commented Sep 18, 2024

I have take a look. And I think I can close this PR. Thanks for implementing it. And since whereSchema needs to be tweaked using operator, I will fork and custom it and republish for meet our dev needs

@fortezhuo fortezhuo closed this Sep 18, 2024
@m1212e
Copy link
Owner

m1212e commented Sep 19, 2024

Thank you very much for your input!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Prisma Select, Include and OrderBy
2 participants