-
Notifications
You must be signed in to change notification settings - Fork 0
Reorganize clone dialog #36
base: development
Are you sure you want to change the base?
Conversation
b54c9d2
to
d53552c
Compare
…acGitverCore with required minor changes
The ProgressWdgt is going to be used internally by ProgressDlg to represent a single activity or step.
An activity must contain at least one step to be processed. Note: There's no logging available yet.
TODO: error state is missing
d53552c
to
6850091
Compare
Activities become invalid, when they where deleted (pointer == nullptr).
… the progress bar
ba21fa4
to
7894f78
Compare
…ag better reflects what I mean here
…viy's result and minor cleanup
7894f78
to
b05f38a
Compare
b05f38a
to
2d36da5
Compare
When a step progress reaches 100%, the progress bar changes to a green background.
The progress dialog is part of the MGV-Core API now.
3610153
to
2e02772
Compare
bool okay = !mCloneWdgt->txtPath->text().isEmpty() && | ||
!mCloneWdgt->txtUrl->text().isEmpty(); | ||
|
||
QDir wanted( QDir::toNativeSeparators( mCloneWdgt->txtPath->text() ) ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fromNativeSeparators
would be fitting better, wouldn't it?
Hey, @antis81, as I'm progressing with everything here a fair bit, I need some code paths to do the actual testing. Here's the steps that need to be done, in order to have a fully working centralised and not content-related progress reporting facility:
Depending on a) your available time and b) your plans for the GitWrap Operations, I'd either take 38 myself and use that code to finish 37 - While you'd be finishing 35 |
Currently time is the least problem I'm worrying about. It's the question of organization. Let me set your points into parts: Part 1 - Move ProgressDlg to libActivities:
Part 2 - Implement the CloneService: Part 3 - Rebase PR #26 onto libActivities Part 4 - Adapt #36 to libActivities
Btw.: It is natural, that bigger chunks of the code become obsolete in the current clone dialog implementation. Don't hesitate to remove/replace those.
Q: Do you like to eat 🍦 or 🍭 better? No, seriously. I'd finish the dialog first as much as possible, but as the service is a basis for that, I think it is better to finish that first. |
The "finished" status of a step is artificially generated through it's progress (>=100%). The progress dialog now does this by itself.
…ed in a non-bare clone context
2e02772
to
97f394d
Compare
Depends on PR #35, which should be merged before this one.