Allow using MainThreadMarker in extern_methods!
#416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
added
enhancement
madsmtm
force-pushed
the
mainthreadmarker-in-extern-methods
branch
from
d817eff
to
7e26dbe
Compare
|
Alternative: Move |
|
Yet another alternative: Handle this outside of |
madsmtm
force-pushed
the
mainthreadmarker-in-extern-methods
branch
from
7e26dbe
to
d90209d
Compare
madsmtm
force-pushed
the
mainthreadmarker-in-extern-methods
branch
from
d90209d
to
962e7a5
Compare
|
Although I don't really like it, I went with it for now, then if we get something like contexts and capabilities then we can rethink this. Also, it may be valuable to do this for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for #359.
Unsure if this can be supported in
declare_class!.