Refactor macro internals #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make it easier to add an attribute like `#[method_family(init)]` in the future.
This slightly regresses UI with invalid syntax, since errors may now be output twice
madsmtm
added
enhancement
madsmtm
force-pushed
the
rewrite-macro-internals
branch
from
0910dee
to
7036e7a
Compare
madsmtm
force-pushed
the
rewrite-macro-internals
branch
from
7036e7a
to
44d2c20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A general cleanup to make the macros more consistent with each other, and to prepare for #457 and similar rewrites of
declare_class!internals