Merge block-sys into block2
#551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is considered a private implementation detail, and is probably not safe to rely on.
madsmtm
force-pushed
the
block-sys-refactor
branch
from
d580081
to
008402c
Compare
madsmtm
force-pushed
the
block-sys-refactor
branch
2 times, most recently
from
b733009
to
20635c8
Compare
`block-sys` doesn't actually build a library, it only links to it, so there is no real need for a build script, nor for the `links` key. Additionally, it should actually only expose the six public symbols, and in that case, it just seems wasteful to have multiple crates. This _does_ remove: 1. The ability to override the linking. This was brittle already, and is probably better handled by dedicated tools / by modifying the binaries after they're compiled / by inserting extra linker commands. 2. The `DEP_BLOCK_0_2_CC_ARGS` environment variable exposed to downstream build scripts. This was not really that useful, usually you want to know exactly what flags you're passing to your compiler, and the standard `-fblocks` flag is enough.
madsmtm
force-pushed
the
block-sys-refactor
branch
from
20635c8
to
056e578
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #168.
block-sysdoesn't actually build a library, it only links to it, so there is no real need for a build script, nor for thelinkskey.Additionally, it should actually only expose the six public symbols, and in that case, it just seems wasteful to have multiple crates.
This does remove:
DEP_BLOCK_0_2_CC_ARGSenvironment variable exposed to downstream build scripts. This was not really that useful, usually you want to know exactly what flags you're passing to your compiler, and the standard-fblocksflag is enough.I will publish a deprecation notice in
block-sysafter this PR.