Redis integration #48
Draft
+135
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maffettone
reviewed
Oct 22, 2024
Comment on lines
+73
to
+75
| HSET tag:1 id 0 family "DICT_APRILTAG_36h11" size 0.02665 sample_name sample_1 | ||
| ``` |
There was a problem hiding this comment.
Can we also add a python example?
| Run the Redis container with the following command (make sure to have the correct binding for the local storage): | ||
| ```bash | ||
| podman run --name redis-container --network host -d -v /home/wfernando1/Documents/Environments/Workspaces/redis/data/:/data -p 6379:6379 redis |
There was a problem hiding this comment.
Do we need to mount a volume? If so, we should specify that this is for persistence.
|
|
||
| # Connect to Redis | ||
| # Note: Change the host IP to map your server. | ||
| client = redis.Redis(host="192.168.56.1", port=6379, db=0) |
There was a problem hiding this comment.
I know this is just a tool for sanity checking, but perhaps we could do this more programmatically with:
podman container inspect -f '{{.NetworkSettings.IPAddress}}' redis-container
Comment on lines
6
to
11
| import rclpy | ||
| from rclpy.action import ActionClient | ||
| from rclpy.node import Node | ||
|
|
||
| from pdf_beamtime_interfaces.action import FidPoseControlMsg | ||
| import redis |
There was a problem hiding this comment.
Suggested change
| import rclpy | |
| from rclpy.action import ActionClient | |
| from rclpy.node import Node | |
| from pdf_beamtime_interfaces.action import FidPoseControlMsg | |
| import redis | |
| import rclpy | |
| from rclpy.action import ActionClient | |
| from rclpy.node import Node | |
| import redis | |
| from pdf_beamtime_interfaces.action import FidPoseControlMsg |
This should fix the isort.
Co-authored-by: Dr. Phil Maffettone <43007690+maffettone@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR connects a Redis database to extract the tag ID corresponding to a given sample.